From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5503FC433EF for ; Wed, 17 Nov 2021 12:56:51 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id A693D63236 for ; Wed, 17 Nov 2021 12:56:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A693D63236 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AF16741104; Wed, 17 Nov 2021 13:56:49 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 934EC407FF for ; Wed, 17 Nov 2021 13:56:47 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id F380D5C0100; Wed, 17 Nov 2021 07:56:46 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 17 Nov 2021 07:56:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= EQ/ftDszXhVk3yCrcsxr+mU25Jr9ayc55DMNNc/g1D8=; b=QsYdONPasyy/WLc2 YnRrPxj9enWF5D22I3CM25LLAZcPycrqKYiQlxzJPtJQ0PdT3cpOLb2nMpucyW7E YP6dGj8gCNh9hSDLyx/twEZUDvLRp1+xg9iQ2ZLD67iAR6OloKbrTTGUW49SM5q9 1qmZh47uZ31dUbPAS/eUwTlFuIqKI9fnqTdreug3zJx9nDmB8aMlgTfEcn6Yc+YB n6FhmN7B6MqQkRXBTIIhhwAg+tBBaHSkqy79EuobfXb1xYBF+eO7ey8Yy8n2kgLs rScDAQru49ub7Nv4yMvHqtx3WX897j3mDGNigzj1emBd6zGJ34m7whsDnav6+/Ao K5j9NA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=EQ/ftDszXhVk3yCrcsxr+mU25Jr9ayc55DMNNc/g1 D8=; b=YeGybm7jzLeoJBgXdmH2oDQtymIMwYdONRKgEvW9TJRJwBAKxuazS5fZu hkGnmj7q/H20AEaoltj11/y0gv4zsfjR9xniXIJSUjfF/5U71+hVbxLBtJy5wlYe qRgoav6lQX28Ovm4zjy37rpV3v8ZR3miSiCILniQ/QzqdXgZVmK1oDcFmHhWis3J pbJ/7fvcOihQ2MCVcECaWOU5rjgPUllepvtgVXc5B/PIT52JoEfiw7hQ7O/Uja48 KAZetu/owdPD19KuD0eqi2NQgf6glBO1Q74Q8OLDLOZiA3DvYHVgg0SJiTYlJCBj XlPv9VOGs5YG0uZEDGr6scXdy9UkA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrfeeggdegudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 17 Nov 2021 07:56:46 -0500 (EST) From: Thomas Monjalon To: Elena Agostini Cc: dev@dpdk.org, bruce.richardson@intel.com Subject: Re: [PATCH v1] build: make gpudev optional Date: Wed, 17 Nov 2021 13:56:44 +0100 Message-ID: <60637329.tll5HmREfJ@thomas> In-Reply-To: <2153320.YCSTWHfduz@thomas> References: <20211117203351.6087-1-eagostini@nvidia.com> <2153320.YCSTWHfduz@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 17/11/2021 13:36, Thomas Monjalon: > 17/11/2021 21:33, eagostini@nvidia.com: > > --- a/app/test-gpudev/meson.build > > +++ b/app/test-gpudev/meson.build > > @@ -1,5 +1,12 @@ > > # SPDX-License-Identifier: BSD-3-Clause > > # Copyright (c) 2021 NVIDIA Corporation & Affiliates > > > > -sources = files('main.c') > > -deps = ['gpudev', 'ethdev'] > > +if dpdk_conf.has('RTE_LIB_GPUDEV') > > + sources = files('main.c') > > + deps = ['gpudev', 'ethdev'] > > +else > > + build = false > > + reason = 'gpudev library is disabled' > > + subdir_done() > > +endif > > I would prefer the form "if not" so we can save the "else". Actually no need to check at all in app and driver. If the dependency is missing the driver is disabled already with this reason: reason = 'missing internal dependency, "@0@"'.format(d) For the app, there is an automatic message: message('Missing dependency "@0@" for app "@1@"'.format(d, name)) > > --- a/lib/meson.build > > +++ b/lib/meson.build > > @@ -76,6 +76,7 @@ optional_libs = [ > > 'pdump', > > 'power', > > 'vhost', > > + 'gpudev', > > ] > > It should be sorted alphabetically.