From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v6] examples: fix RSS hash function configuration Date: Thu, 5 Jul 2018 14:09:45 +0100 Message-ID: <60d13d57-8755-bdcb-15c8-bc2673ad30dd@intel.com> References: <20180703180820.7462-1-ferruh.yigit@intel.com> <20180704200222.60945-1-ferruh.yigit@intel.com> <58a5a149-5653-4ba9-4397-2a1dd74d4a6b@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, Liang Ma , Xueming Li , Pavan Nikhilesh To: "Hunt, David" , Jerin Jacob , Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , Declan Doherty , Chas Williams , Bruce Richardson , Harry van Haaren , Cristian Dumitrescu , Konstantin Ananyev , Remy Horton , Ori Kam , Pablo de Lara , Radu Nicolau , Akhil Goyal , Tomasz Kantecki , Anatoly Burakov , John McNamara , Xiaoyun Li , Thomas Monjalon , Andrew Ry Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 629A82BDB for ; Thu, 5 Jul 2018 15:09:53 +0200 (CEST) In-Reply-To: <58a5a149-5653-4ba9-4397-2a1dd74d4a6b@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 7/5/2018 10:30 AM, Hunt, David wrote: > Hi Ferruh, > > > On 4/7/2018 9:02 PM, Ferruh Yigit wrote: >> ethdev layer introduced checks for application requested RSS hash >> functions and returns error for ones unsupported by hardware >> >> This check breaks some sample applications which blindly configures >> RSS hash functions without checking underlying hardware support. >> >> Updated examples to mask out unsupported RSS has functions during device >> configuration. >> Prints a log if configuration values updated by this check. >> >> Fixes: aa1a6d87f15d ("ethdev: force RSS offload rules again") >> >> Signed-off-by: Ferruh Yigit Tested-by: Meijuan Zhao Tested-by: Yingya Han > Acked-by: David Hunt Applied to dpdk-next-net/master, thanks.