From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] librte_ip_frag: Disable ipv4/v6 fragmentation if RTE_MBUF_REFCNT=n Date: Tue, 21 Oct 2014 23:11:35 +0200 Message-ID: <6121476.at0lcZkNCO@xps13> References: <1413900943-27711-1-git-send-email-pablo.de.lara.guarch@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Pablo de Lara Return-path: In-Reply-To: <1413900943-27711-1-git-send-email-pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-10-21 15:15, Pablo de Lara: > Ipv4/v6 fragmentation libraries depends on refcnt. > There was a compilation error if RTE_MBUF_REFCNT was disabled, > so those libraries have been disabled in that situation. Please Pablo, could you add a short justification that it's not possible to implement fragmentation without refcnt (at least with the current design)? What do you think of adding a warning as below? > +ifeq ($(CONFIG_RTE_MBUF_REFCNT),y) > SRCS-$(CONFIG_RTE_LIBRTE_IP_FRAG) += rte_ipv4_fragmentation.c > -SRCS-$(CONFIG_RTE_LIBRTE_IP_FRAG) += rte_ipv4_reassembly.c > SRCS-$(CONFIG_RTE_LIBRTE_IP_FRAG) += rte_ipv6_fragmentation.c +else +$(info WARNING: Fragmentation feature is disabled because it needs MBUF_REFCNT.) > +endif > +SRCS-$(CONFIG_RTE_LIBRTE_IP_FRAG) += rte_ipv4_reassembly.c -- Thomas