From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] bond: fix for mac assignment to slaves device Date: Thu, 11 Dec 2014 02:01:55 +0100 Message-ID: <6126891.ZxNGlZ50TB@xps13> References: <1417800885-18643-1-git-send-email-declan.doherty@intel.com> <1418037572-6546-1-git-send-email-declan.doherty@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: "Doherty, Declan" Return-path: In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" > > -V2: > > Tidies up the slave_remove function as per Pawel's comments. > > > > Adding call to mac_address_slaves_update from the lsc handler when the > > first slave become active to propagate any mac changes made while > > devices are inactive > > > > Changed removing slave logic to use memmove instead of memcpy to move > > data within the same array, as this was corrupting the slave array. > > > > Adding unit test to cover failing assignment scenarios > > > > Signed-off-by: Declan Doherty > > Acked-by: Wodkowski, Pawel Applied Thanks -- Thomas