From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] eal: add missing include to debug header Date: Thu, 05 May 2016 22:49:10 +0200 Message-ID: <6139507.vNs2NSYtOk@xps13> References: <1462379876-21901-1-git-send-email-bruce.richardson@intel.com> <20160505125942.GA14228@bricha3-MOBL3> <572B6FDE.4000209@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Ferruh Yigit To: Bruce Richardson Return-path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 6CC055592 for ; Thu, 5 May 2016 22:49:12 +0200 (CEST) Received: by mail-wm0-f52.google.com with SMTP id e201so34885598wme.0 for ; Thu, 05 May 2016 13:49:12 -0700 (PDT) In-Reply-To: <572B6FDE.4000209@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-05-05 17:07, Ferruh Yigit: > On 5/5/2016 1:59 PM, Bruce Richardson wrote: > > On Wed, May 04, 2016 at 05:37:56PM +0100, Bruce Richardson wrote: > >> The header file rte_debug.h makes use of the "unlikely" macro which > >> means it should include the rte_branch_prediction.h header file. > >> > >> Fixes: 50705e8e3cdd ("eal: add assert macro for debug") > >> > >> Signed-off-by: Bruce Richardson > > > > Ping on this patch - any comments or concerns? > > It's a fairly trivial fix that prevents issues with testing some other patches > > on the mainline. > > > > Tested on top of David Marchand's 12123-12139 patchset. > > Acked-by: Ferruh Yigit Applied, thanks Sorry for the delay, I was gardening today :)