From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] scripts: add check for net driver names
	without net prefix
Date: Wed, 06 Jul 2016 11:10:48 +0200
Message-ID: <6142444.k3HLHFvhXo@xps13>
References: <1467729650-925-1-git-send-email-bruce.richardson@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, nelio.laranjeiro@6wind.com
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49])
 by dpdk.org (Postfix) with ESMTP id F399D69FE
 for <dev@dpdk.org>; Wed,  6 Jul 2016 11:10:50 +0200 (CEST)
Received: by mail-wm0-f49.google.com with SMTP id r201so184005170wme.1
 for <dev@dpdk.org>; Wed, 06 Jul 2016 02:10:50 -0700 (PDT)
In-Reply-To: <1467729650-925-1-git-send-email-bruce.richardson@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-07-05 15:40, Bruce Richardson:
> +# check headline label for net/ prefix if needed
> +bad=$(echo "$headlines" | grep -E --color=always \
> +	-e "^($(ls drivers/net | grep -v Makefile | tr '\n' '|')):" \
> +	| sed 's,^,\t,')
> +[ -z "$bad" ] || printf "Headline missing 'net/' prefix:\n$bad\n"

This check is definitely a good idea.
We need the same thing for crypto.
Few nits:
- -E is not needed for this regex
- "/base:" cases are not handled because of the colon at the end
of the regex.
- patches touching several drivers are not handled. Examples:
  "mlx:" -> "net/mlx:"
  "drivers/net:" -> "net:"

By the way, I am looking at an idea, that Nelio sent me, based on
modified files. It can complete this check.