From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] app/testpmd: fix failing to enable SW checksum calculation Date: Wed, 31 Jan 2018 23:34:06 +0100 Message-ID: <6151298.L9tu3aqMsX@xps> References: <1516846424-19929-1-git-send-email-jiayu.hu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Shahaf Shuler , "wenzhuo.lu@intel.com" , "lei.a.yao@intel.com" To: Jiayu Hu Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id B28F31B858 for ; Wed, 31 Jan 2018 23:34:54 +0100 (CET) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 25/01/2018 07:54, Shahaf Shuler: > Hi Jiayu Hu, > > Good fix, thanks. > > Thursday, January 25, 2018 4:14 AM, Jiayu Hu: > > In current design, we can't enable SW checksum calculation for the devices > > which don't have checksum offloading abilities via the command "csum set > > ip|tcp|udp|sctp|outer-ip sw ". > > But SW checksum calculation shouldn't depend on HW offloading abilities. > > This patch is to fix this issue. > > > > Fixes: 3926dd2b6668 ("app/testpmd: enforce offload capabilities check") > > Signed-off-by: Jiayu Hu > > Reviewed-by: Shahaf Shuler Applied, thanks