From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v3 2/2] ethdev: add hierarchical scheduler API
Date: Mon, 06 Mar 2017 11:38:42 +0100
Message-ID: <6158991.OypYtkqGNY@xps13>
References: <1488589820-206947-1-git-send-email-cristian.dumitrescu@intel.com>
 <1488589820-206947-3-git-send-email-cristian.dumitrescu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com,
 balasubramanian.manoharan@cavium.com, hemant.agrawal@nxp.com,
 shreyansh.jain@nxp.com
To: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48])
 by dpdk.org (Postfix) with ESMTP id 7723C3DC
 for <dev@dpdk.org>; Mon,  6 Mar 2017 11:38:44 +0100 (CET)
Received: by mail-wm0-f48.google.com with SMTP id n11so60548378wma.0
 for <dev@dpdk.org>; Mon, 06 Mar 2017 02:38:44 -0800 (PST)
In-Reply-To: <1488589820-206947-3-git-send-email-cristian.dumitrescu@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2017-03-04 01:10, Cristian Dumitrescu:
> This patch introduces the generic ethdev API for the traffic manager
> capability, which includes: hierarchical scheduling, traffic shaping,
> congestion management, packet marking.

We already have some API for QoS. Why integrating them in ethdev?
ethdev is an interface for networking drivers.
I think the QoS has nothing to do with drivers.
If there are some operations to offload in drivers, please identify them
and let's add the operations to ethdev.

> Main features:
> - Exposed as ethdev plugin capability (similar to rte_flow approach)

I do not know what you call an ethdev plugin.
rte_flow is a part of the driver interface.