From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: mbuf offload flags Date: Thu, 16 Jul 2015 11:38:34 +0200 Message-ID: <6168490.VZvRJEXbFC@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: helin.zhang@intel.com Return-path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by dpdk.org (Postfix) with ESMTP id EFF4B902 for ; Thu, 16 Jul 2015 11:39:45 +0200 (CEST) Received: by widic2 with SMTP id ic2so10260374wid.0 for ; Thu, 16 Jul 2015 02:39:45 -0700 (PDT) List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Helin, In commit http://dpdk.org/browse/dpdk/commit/?id=c22265f6fd4cdc, some fake flags were added: #define PKT_RX_EIP_CKSUM_BAD (0ULL << 0) /**< External IP header checksum error. */ #define PKT_RX_OVERSIZE (0ULL << 0) /**< Num of desc of an RX pkt oversize. */ #define PKT_RX_HBUF_OVERFLOW (0ULL << 0) /**< Header buffer overflow. */ #define PKT_RX_RECIP_ERR (0ULL << 0) /**< Hardware processing error. */ #define PKT_RX_MAC_ERR (0ULL << 0) /**< MAC error. */ Can we remove them? In a tunnel case, what means PKT_RX_IP_CKSUM_BAD and PKT_RX_L4_CKSUM_BAD? Inner or outer? The API comment must be updated.