From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hemant Agrawal <hemant.agrawal@nxp.com>
Subject: Re: [PATCH] examples/load_balancer: enable the build for
 lesser lcores
Date: Wed, 19 Jul 2017 13:27:49 +0530
Message-ID: <616bec5e-b312-c72e-2be2-e0013528c416@nxp.com>
References: <1500280902-7333-1-git-send-email-hemant.agrawal@nxp.com>
 <1782606.ZZX3YYOCMi@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <dev@dpdk.org>
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM01-BN3-obe.outbound.protection.outlook.com
 (mail-bn3nam01on0052.outbound.protection.outlook.com [104.47.33.52])
 by dpdk.org (Postfix) with ESMTP id F162E374F
 for <dev@dpdk.org>; Wed, 19 Jul 2017 09:57:55 +0200 (CEST)
In-Reply-To: <1782606.ZZX3YYOCMi@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 7/19/2017 10:51 AM, Thomas Monjalon wrote:
> 17/07/2017 11:41, Hemant Agrawal:
>> --- a/examples/load_balancer/main.h
>> +++ b/examples/load_balancer/main.h
>>  #ifndef APP_MAX_IO_LCORES
>> +#if (APP_MAX_LCORES > 16)
>>  #define APP_MAX_IO_LCORES 16
>> +#else
>> +#define APP_MAX_IO_LCORES APP_MAX_LCORES
>>  #endif
>> -#if (APP_MAX_IO_LCORES > APP_MAX_LCORES)
>> -#error "APP_MAX_IO_LCORES is too big"
>>  #endif
> [...]
>>  #ifndef APP_MAX_WORKER_LCORES
>> +#if (APP_MAX_LCORES > 16)
>>  #define APP_MAX_WORKER_LCORES 16
>> +#else
>> +#define APP_MAX_WORKER_LCORES APP_MAX_LCORES
>>  #endif
>> -#if (APP_MAX_WORKER_LCORES > APP_MAX_LCORES)
>> -#error "APP_MAX_WORKER_LCORES is too big"
>>  #endif
>
> Why removing the checks > APP_MAX_LCORES ?
>
It is not going to be needed unless someone defines it.
I will send v2 with reverting them back.