From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 1/8] net/qede: fix to disable per-VF Tx switching feature Date: Wed, 08 Nov 2017 02:44:40 +0100 Message-ID: <6189711.sNO2pZEAvp@xps> References: <1510043665-8160-1-git-send-email-rasesh.mody@cavium.com> <3022250.CEjPREgbVS@xps> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: "ferruh.yigit@intel.com" , dev@dpdk.org, Dept-Eng DPDK Dev , "Mody, Rasesh" To: "Patil, Harish" Return-path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 1BB021B2C7 for ; Wed, 8 Nov 2017 02:44:42 +0100 (CET) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 08/11/2017 02:34, Patil, Harish: > >> --- a/config/common_base > >> +++ b/config/common_base > >> +CONFIG_RTE_LIBRTE_QEDE_VF_TX_SWITCH=n > > > >We should remove all compile-time options because they cannot be used > >when DPDK is pre-packaged. > >That's why the rule is "NO NEW COMPILE TIME OPTION". > > > >After discussion with Ferruh, this patch is accepted as a hotfix. > >But this option is expected to be removed quickly. > >I've sent a patch to remove this option in 18.02: > > http://dpdk.org/ml/archives/dev/2017-November/081488.html > >It gives you some time to supersede my patch by introducing a > >run-time driver option. > > > >Thanks > > Hi Thomas, > Sure, thanks, we will address before 18.02-rc1. > Do you have any example on how to add a run-time driver option? > Does it mean to introduce some change in ethdev? It is done by parsing devargs with rte_kvargs. Examples: http://dpdk.org/commit/447e0d379 http://dpdk.org/commit/001a520e4 http://dpdk.org/commit/7958b1310