From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 1/3] eal: enable uio_pci_generic support Date: Fri, 20 Feb 2015 10:01:10 +0100 Message-ID: <61932075.MLJK3iMSUs@xps13> References: <1424365731-32228-1-git-send-email-danny.zhou@intel.com> <1424365731-32228-2-git-send-email-danny.zhou@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Zhou Danny Return-path: In-Reply-To: <1424365731-32228-2-git-send-email-danny.zhou-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi Danny, 2015-02-20 01:08, Zhou Danny: > @@ -148,6 +151,7 @@ struct rte_pci_device { > struct rte_pci_id id; /**< PCI ID. */ > struct rte_pci_resource mem_resource[PCI_MAX_RESOURCE]; /**< PCI Memory Resource */ > struct rte_intr_handle intr_handle; /**< Interrupt handle */ > + char kernel_driver_name[BUFSIZ]; /**< Kernel driver name */ The comment is not very helpful. What about something like "Kernel driver to map ressources in userspace"? You are introducing a new field without filling it for UIO and VFIO. Testuya and Michael are working on the same thing in hotplug patchset: http://dpdk.org/dev/patchwork/patch/3520/ Please help to choose the best approach. > const struct rte_pci_driver *driver; /**< Associated driver */