From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH 2/7] ethdev: fix port id storage
Date: Fri, 1 Dec 2017 15:52:08 -0800
Message-ID: <61b4477c-afcb-9459-c132-3c2a45e227c0@intel.com>
References: <20171201022957.64329-1-ferruh.yigit@intel.com>
 <20171201022957.64329-2-ferruh.yigit@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org, vladz@cloudius-systems.com, stable@dpdk.org,
 declan.doherty@intel.com, Boris Pismenny <borisp@mellanox.com>,
 Aviad Yehezkel <aviadye@mellanox.com>, Radu Nicolau <radu.nicolau@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <20171201022957.64329-2-ferruh.yigit@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 11/30/2017 6:29 PM, Ferruh Yigit wrote:
> port_id is now 16bits, update function parameter according.
> 
> Fixes: 4c270218aa26 ("ethdev: support security APIs")
> Cc: stable@dpdk.org
> Cc: declan.doherty@intel.com
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> Cc: Boris Pismenny <borisp@mellanox.com>
> Cc: Aviad Yehezkel <aviadye@mellanox.com>
> Cc: Radu Nicolau <radu.nicolau@intel.com>
> Cc: Declan Doherty <declan.doherty@intel.com>
> ---

<...>

>  
>  void *
> -rte_eth_dev_get_sec_ctx(uint8_t port_id);
> +rte_eth_dev_get_sec_ctx(uint16_t port_id);

Hi Declan,

Since this is a public API, it needs API documentation. Can you please send a
patch to add doxygen comments the the API?

Thanks,
ferruh

>  
>  struct rte_eth_dev_sriov {
>  	uint8_t active;               /**< SRIOV is active with 16, 32 or 64 pools */
>