From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v6 00/16] Flow API overhaul for switch offloads Date: Wed, 25 Apr 2018 18:34:52 +0100 Message-ID: <61d46aea-12a0-9bc8-d09a-2639fed4bbc6@intel.com> References: <20180419100848.6178-1-adrien.mazarguil@6wind.com> <20180425151852.7676-1-adrien.mazarguil@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: Adrien Mazarguil , Thomas Monjalon , dev@dpdk.org Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 5158C5F29 for ; Wed, 25 Apr 2018 19:34:55 +0200 (CEST) In-Reply-To: <20180425151852.7676-1-adrien.mazarguil@6wind.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/25/2018 4:27 PM, Adrien Mazarguil wrote: > As summarized in a prior RFC [1], the flow API (rte_flow) was chosen as a > means to manage switch offloads supported by many devices (usually going by > names such as E-Switch or vSwitch) through user-specified flow rules. > > Combined with the need to support encap/decap actions, this requires a > change in the way flow actions are processed (in order and possibly > repeated) which modifies the behavior of some of the existing actions, thus > warranting a major ABI breakage. > > Given this ABI breakage is also required by other work submitted for the > current release [2][3], this series addresses various longstanding issues > with the flow API and makes minor improvements in preparation for upcoming > features. > > Changes summary: > > - Additional error types. > - Clearer documentation. > - Improved C++ compatibility. > - Exhaustive RSS action. > - Consistent behavior of VLAN pattern item. > - New "transfer" attribute bringing consistency to VF/PF pattern items. > - Confusing "PORT" pattern item renamed "PHY_PORT", with new action > counterpart. > - New "PORT_ID" pattern item and action to be used with port representors. > > This series piggybacks on the major ABI update introduced by a prior > commit [4] for DPDK 18.05 and depends on several fixes [5] which must be > applied first. > > [1] "[RFC] Switch device offload with DPDK" > http://dpdk.org/ml/archives/dev/2018-March/092513.html > > [2] commit 676b605182a5 ("doc: announce ethdev API change for RSS > configuration") > > [3] "[PATCH v1 00/21] MLX5 tunnel Rx offloading" > http://dpdk.org/ml/archives/dev/2018-March/092264.html > > [4] commit 653e038efc9b ("ethdev: remove versioning of filter control > function") > > [5] "[PATCH v6 00/11] Bunch of flow API-related fixes" > http://dpdk.org/ml/archives/dev/2018-April/098035.html > > v6 changes: > > - Fixed mlx5 issue raised by Nelio in "ethdev: flatten RSS configuration in > flow API". > - Updated release notes (API update / ABI breakage) in relevant patches. > - Removed Xueming's deprecation notice in "ethdev: add encap level to RSS > flow API action" since it's covered by this series. > - Reworded a few patches as fixes since they address API flaws. > - Rebased series once again. > > v5 changes: > > - Fixed errors reported by GCC and Clang in patch 05/16 ("ethdev: alter > behavior of flow API actions"). > - Rebased series once again. > > v4 changes: > > - No change besides new acked-by lines, rebased series to address conflicts. > > v3 changes: > > - Rebased series, fixed latest conflicts. > - Addressed Andrew's comments, see affected patches for details: > - Empty RSS types in flow rule means PMD-specific RSS instead of no RSS. > - RSS hash function now explicitly compared against > RTE_ETH_HASH_FUNCTION_DEFAULT instead of 0 in all PMDs. > - sfc PMD updated to also accept Toeplitz. > - Implicit VLAN TPID matching now removed from all PMDs. > - Default mask upate for VLAN TCI now split as separate patch #11. > - Ingress/egress definition clarified in patch #12. > > v2 changes: > > - Squashed "ethdev: update ABI for flow API functions" in subsequent > patches. > - Emphasized ABI impact in relevant commit logs. > - Modified documentation in "ethdev: alter behavior of flow API actions" to > describe how terminating flow rules without any action of the fate kind > result in undefined behavior instead of dropping traffic. > - Fixed other minor documentation formatting issues. > - Modified "ethdev: refine TPID handling in flow API" as follows: > - Using standard macro definitions for VLAN, QinQ and E-Tag EtherTypes. > - Fixed endian conversion in sfc. > - Replaced a condition in VLAN pattern item processing with an assertion > check for i40e. > > Adrien Mazarguil (16): > ethdev: add error types to flow API > ethdev: clarify flow API pattern items and actions > doc: remove flow API migration section > ethdev: remove DUP action from flow API > ethdev: alter behavior of flow API actions > ethdev: fix C99 flexible arrays from flow API > ethdev: flatten RSS configuration in flow API > ethdev: add hash function to RSS flow API action > ethdev: add encap level to RSS flow API action > ethdev: fix TPID handling in flow API > ethdev: fix default VLAN TCI mask in flow API > ethdev: add transfer attribute to flow API > ethdev: fix behavior of VF/PF in flow API > ethdev: rename physical port item in flow API > ethdev: add physical port action to flow API > ethdev: add port ID item and action to flow API Series applied to dpdk-next-net/master, thanks.