From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v4 11/15] mbuf: rename physical address to
	IOVA
Date: Mon, 06 Nov 2017 17:00:17 +0100
Message-ID: <6210686.83tBtOY6zu@xps>
References: <20170814151537.29454-1-santosh.shukla@caviumnetworks.com>
 <20171106014141.13266-12-thomas@monjalon.net>
 <20171106155245.fvc7toh62gxpxros@platinum>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: Santosh Shukla <santosh.shukla@caviumnetworks.com>,
 sergio.gonzalez.monroy@intel.com, anatoly.burakov@intel.com, dev@dpdk.org,
 hemant.agrawal@nxp.com, shreyansh.jain@nxp.com
To: Olivier MATZ <olivier.matz@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id E68901B1BB
 for <dev@dpdk.org>; Mon,  6 Nov 2017 17:00:19 +0100 (CET)
In-Reply-To: <20171106155245.fvc7toh62gxpxros@platinum>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

06/11/2017 16:52, Olivier MATZ:
> On Mon, Nov 06, 2017 at 02:41:37AM +0100, Thomas Monjalon wrote:
> > From: Santosh Shukla <santosh.shukla@caviumnetworks.com>
> > 
> > Rename buf_physaddr to buf_iova.
> > Keep the deprecated name in an anonymous union to avoid breaking
> > the API.
> > 
> > Signed-off-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
> > Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> 
> Just be aware that I still see some references to ->buf_physaddr.
> 
> $ git grep buf_physaddr
> drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:    op->sym->aead.digest.phys_addr = mbuf->buf_physaddr;
> drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:    mbuf->buf_physaddr = (uint64_t)op;
> drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:    op = (struct rte_crypto_op *)mbuf->buf_physaddr;
> drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:    mbuf->buf_physaddr = op->sym->aead.digest.phys_addr;
> drivers/crypto/dpaa_sec/dpaa_sec.c:     src_start_addr = sym->m_src->buf_physaddr + sym->m_src->data_off;
> drivers/crypto/dpaa_sec/dpaa_sec.c:             dst_start_addr = sym->m_dst->buf_physaddr + sym->m_dst->data_off;
> lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h:  uint64_t buf_physaddr;
> lib/librte_eal/linuxapp/kni/kni_net.c:                  (unsigned long)m->buf_physaddr);
> lib/librte_eal/linuxapp/kni/kni_net.c:  return phys_to_virt(m->buf_physaddr + m->data_off);
> lib/librte_eal/linuxapp/kni/kni_net.c:                   (unsigned long)m->buf_physaddr));
> lib/librte_mbuf/rte_mbuf.h:             rte_iova_t buf_physaddr; /**< deprecated */

Yes, it is on purpose.
KNI is known to work only with physical addresses for now.
I am not sure about NXP buses, but I had the feeling that it deserves a
separate work.