From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ola Liljedahl Subject: Re: [PATCH v3 1/3] ring: read tail using atomic load Date: Fri, 5 Oct 2018 11:36:41 +0000 Message-ID: <621E373E-048D-4808-8CE8-84373EA98D2F@arm.com> References: <20180807031943.5331-1-gavin.hu@arm.com> <1537172244-64874-1-git-send-email-gavin.hu@arm.com> <20180929104857.GA30457@jerin> <2601191342CEEE43887BDE71AB9772580102FE261A@IRSMSX106.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: "dev@dpdk.org" , Honnappa Nagarahalli , Steve Capper , nd , "stable@dpdk.org" To: "Ananyev, Konstantin" , "Gavin Hu (Arm Technology China)" , Jerin Jacob Return-path: In-Reply-To: Content-Language: en-US Content-ID: <9A33209B82996D47A3ED588270C0A7DB@eurprd08.prod.outlook.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" aHR0cHM6Ly9lbi5jcHByZWZlcmVuY2UuY29tL3cvY3BwL2xhbmd1YWdlL21lbW9yeV9tb2RlbA0K PHF1b3RlPg0KV2hlbiBhbiBldmFsdWF0aW9uIG9mIGFuIGV4cHJlc3Npb24gd3JpdGVzIHRvIGEg bWVtb3J5IGxvY2F0aW9uIGFuZCBhbm90aGVyIGV2YWx1YXRpb24gcmVhZHMgb3IgbW9kaWZpZXMg dGhlIHNhbWUgbWVtb3J5IGxvY2F0aW9uLCB0aGUgZXhwcmVzc2lvbnMgYXJlIHNhaWQgdG8gY29u ZmxpY3QuIEEgcHJvZ3JhbSB0aGF0IGhhcyB0d28gY29uZmxpY3RpbmcgZXZhbHVhdGlvbnMgaGFz IGEgZGF0YSByYWNlIHVubGVzcw0KDQoqIGJvdGggZXZhbHVhdGlvbnMgZXhlY3V0ZSBvbiB0aGUg c2FtZSB0aHJlYWQgb3IgaW4gdGhlIHNhbWUgc2lnbmFsIGhhbmRsZXIsIG9yDQoqIGJvdGggY29u ZmxpY3RpbmcgZXZhbHVhdGlvbnMgYXJlIGF0b21pYyBvcGVyYXRpb25zIChzZWUgc3RkOjphdG9t aWMpLCBvcg0KKiBvbmUgb2YgdGhlIGNvbmZsaWN0aW5nIGV2YWx1YXRpb25zIGhhcHBlbnMtYmVm b3JlIGFub3RoZXIgKHNlZSBzdGQ6Om1lbW9yeV9vcmRlcikNCklmIGEgZGF0YSByYWNlIG9jY3Vy cywgdGhlIGJlaGF2aW9yIG9mIHRoZSBwcm9ncmFtIGlzIHVuZGVmaW5lZC4NCjwvcXVvdGU+DQoN CkMxMSBhbmQgQysrMTEgaGF2ZSB0aGUgc2FtZSBtZW1vcnkgbW9kZWwgKG90aGVyd2lzZSBpbnRl cm9wZXJhYmlsaXR5IHdvdWxkIGJlIGRpZmZpY3VsdCkuDQoNCk9yIGFzIEplZmYgUHJlc2hpbmcg ZXhwbGFpbnMgaXQ6DQoiQW55IHRpbWUgdHdvIHRocmVhZHMgb3BlcmF0ZSBvbiBhIHNoYXJlZCB2 YXJpYWJsZSBjb25jdXJyZW50bHksIGFuZCBvbmUgb2YgdGhvc2Ugb3BlcmF0aW9ucyBwZXJmb3Jt cyBhIHdyaXRlLCBib3RoIHRocmVhZHMgbXVzdCB1c2UgYXRvbWljIG9wZXJhdGlvbnMuIg0KaHR0 cHM6Ly9wcmVzaGluZy5jb20vMjAxMzA2MTgvYXRvbWljLXZzLW5vbi1hdG9taWMtb3BlcmF0aW9u cy8NCg0KU28gaWYgaHQtPnRhaWwgaXMgd3JpdHRlbiB1c2luZyBlLmcuIF9fYXRvbWljX3N0b3Jl X24oJmh0LT50YWlsLCB2YWwsIG1vKSwgd2UgbmVlZCB0byBhbHNvIHJlYWQgaXQgdXNpbmcgZS5n LiBfX2F0b21pY19sb2FkX24oKS4NCg0KLS0gT2xhDQoNCg0K77u/T24gMDUvMTAvMjAxOCwgMTM6 MTUsICJPbGEgTGlsamVkYWhsIiA8T2xhLkxpbGplZGFobEBhcm0uY29tPiB3cm90ZToNCg0KICAg IA0KICAgIA0KICAgIE9uIDA1LzEwLzIwMTgsIDEwOjIyLCAiQW5hbnlldiwgS29uc3RhbnRpbiIg PGtvbnN0YW50aW4uYW5hbnlldkBpbnRlbC5jb20+IHdyb3RlOg0KICAgIA0KICAgICAgICANCiAg ICAgICAgDQogICAgICAgID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCiAgICAgICAgPiBG cm9tOiBkZXYgW21haWx0bzpkZXYtYm91bmNlc0BkcGRrLm9yZ10gT24gQmVoYWxmIE9mIEdhdmlu IEh1IChBcm0gVGVjaG5vbG9neSBDaGluYSkNCiAgICAgICAgPiBTZW50OiBGcmlkYXksIE9jdG9i ZXIgNSwgMjAxOCAxOjQ3IEFNDQogICAgICAgID4gVG86IEplcmluIEphY29iIDxqZXJpbi5qYWNv YkBjYXZpdW1uZXR3b3Jrcy5jb20+DQogICAgICAgID4gQ2M6IGRldkBkcGRrLm9yZzsgSG9ubmFw cGEgTmFnYXJhaGFsbGkgPEhvbm5hcHBhLk5hZ2FyYWhhbGxpQGFybS5jb20+OyBTdGV2ZSBDYXBw ZXIgPFN0ZXZlLkNhcHBlckBhcm0uY29tPjsgT2xhIExpbGplZGFobA0KICAgICAgICA+IDxPbGEu TGlsamVkYWhsQGFybS5jb20+OyBuZCA8bmRAYXJtLmNvbT47IHN0YWJsZUBkcGRrLm9yZw0KICAg ICAgICA+IFN1YmplY3Q6IFJlOiBbZHBkay1kZXZdIFtQQVRDSCB2MyAxLzNdIHJpbmc6IHJlYWQg dGFpbCB1c2luZyBhdG9taWMgbG9hZA0KICAgICAgICA+IA0KICAgICAgICA+IEhpIEplcmluLA0K ICAgICAgICA+IA0KICAgICAgICA+IFRoYW5rcyBmb3IgeW91ciByZXZpZXcsIGlubGluZSBjb21t ZW50cyBmcm9tIG91ciBpbnRlcm5hbCBkaXNjdXNzaW9ucy4NCiAgICAgICAgPiANCiAgICAgICAg PiBCUi4gR2F2aW4NCiAgICAgICAgPiANCiAgICAgICAgPiA+IC0tLS0tT3JpZ2luYWwgTWVzc2Fn ZS0tLS0tDQogICAgICAgID4gPiBGcm9tOiBKZXJpbiBKYWNvYiA8amVyaW4uamFjb2JAY2F2aXVt bmV0d29ya3MuY29tPg0KICAgICAgICA+ID4gU2VudDogU2F0dXJkYXksIFNlcHRlbWJlciAyOSwg MjAxOCA2OjQ5IFBNDQogICAgICAgID4gPiBUbzogR2F2aW4gSHUgKEFybSBUZWNobm9sb2d5IENo aW5hKSA8R2F2aW4uSHVAYXJtLmNvbT4NCiAgICAgICAgPiA+IENjOiBkZXZAZHBkay5vcmc7IEhv bm5hcHBhIE5hZ2FyYWhhbGxpDQogICAgICAgID4gPiA8SG9ubmFwcGEuTmFnYXJhaGFsbGlAYXJt LmNvbT47IFN0ZXZlIENhcHBlcg0KICAgICAgICA+ID4gPFN0ZXZlLkNhcHBlckBhcm0uY29tPjsg T2xhIExpbGplZGFobCA8T2xhLkxpbGplZGFobEBhcm0uY29tPjsgbmQNCiAgICAgICAgPiA+IDxu ZEBhcm0uY29tPjsgc3RhYmxlQGRwZGsub3JnDQogICAgICAgID4gPiBTdWJqZWN0OiBSZTogW1BB VENIIHYzIDEvM10gcmluZzogcmVhZCB0YWlsIHVzaW5nIGF0b21pYyBsb2FkDQogICAgICAgID4g Pg0KICAgICAgICA+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCiAgICAgICAgPiA+ID4g RGF0ZTogTW9uLCAxNyBTZXAgMjAxOCAxNjoxNzoyMiArMDgwMA0KICAgICAgICA+ID4gPiBGcm9t OiBHYXZpbiBIdSA8Z2F2aW4uaHVAYXJtLmNvbT4NCiAgICAgICAgPiA+ID4gVG86IGRldkBkcGRr Lm9yZw0KICAgICAgICA+ID4gPiBDQzogZ2F2aW4uaHVAYXJtLmNvbSwgSG9ubmFwcGEuTmFnYXJh aGFsbGlAYXJtLmNvbSwNCiAgICAgICAgPiA+ID4gc3RldmUuY2FwcGVyQGFybS5jb20sICBPbGEu TGlsamVkYWhsQGFybS5jb20sDQogICAgICAgID4gPiA+IGplcmluLmphY29iQGNhdml1bW5ldHdv cmtzLmNvbSwgbmRAYXJtLmNvbSwgIHN0YWJsZUBkcGRrLm9yZw0KICAgICAgICA+ID4gPiBTdWJq ZWN0OiBbUEFUQ0ggdjMgMS8zXSByaW5nOiByZWFkIHRhaWwgdXNpbmcgYXRvbWljIGxvYWQNCiAg ICAgICAgPiA+ID4gWC1NYWlsZXI6IGdpdC1zZW5kLWVtYWlsIDIuNy40DQogICAgICAgID4gPiA+ DQogICAgICAgID4gPiA+IEV4dGVybmFsIEVtYWlsDQogICAgICAgID4gPiA+DQogICAgICAgID4g PiA+IEluIHVwZGF0ZV90YWlsLCByZWFkIGh0LT50YWlsIHVzaW5nIF9fYXRvbWljX2xvYWQuQWx0 aG91Z2ggdGhlDQogICAgICAgID4gPiA+IGNvbXBpbGVyIGN1cnJlbnRseSBzZWVtcyB0byBiZSBk b2luZyB0aGUgcmlnaHQgdGhpbmcgZXZlbiB3aXRob3V0DQogICAgICAgID4gPiA+IF9hdG9taWNf bG9hZCwgd2UgZG9uJ3Qgd2FudCB0byBnaXZlIHRoZSBjb21waWxlciBmcmVlZG9tIHRvIG9wdGlt aXNlDQogICAgICAgID4gPiA+IHdoYXQgc2hvdWxkIGJlIGFuIGF0b21pYyBsb2FkLCBpdCBzaG91 bGQgbm90IGJlIGFyYml0YXJpbHkgbW92ZWQNCiAgICAgICAgPiA+ID4gYXJvdW5kLg0KICAgICAg ICA+ID4gPg0KICAgICAgICA+ID4gPiBGaXhlczogMzkzNjhlYmZjNiAoInJpbmc6IGludHJvZHVj ZSBDMTEgbWVtb3J5IG1vZGVsIGJhcnJpZXIgb3B0aW9uIikNCiAgICAgICAgPiA+ID4gQ2M6IHN0 YWJsZUBkcGRrLm9yZw0KICAgICAgICA+ID4gPg0KICAgICAgICA+ID4gPiBTaWduZWQtb2ZmLWJ5 OiBHYXZpbiBIdSA8Z2F2aW4uaHVAYXJtLmNvbT4NCiAgICAgICAgPiA+ID4gUmV2aWV3ZWQtYnk6 IEhvbm5hcHBhIE5hZ2FyYWhhbGxpIDxIb25uYXBwYS5OYWdhcmFoYWxsaUBhcm0uY29tPg0KICAg ICAgICA+ID4gPiBSZXZpZXdlZC1ieTogU3RldmUgQ2FwcGVyIDxzdGV2ZS5jYXBwZXJAYXJtLmNv bT4NCiAgICAgICAgPiA+ID4gUmV2aWV3ZWQtYnk6IE9sYSBMaWxqZWRhaGwgPE9sYS5MaWxqZWRh aGxAYXJtLmNvbT4NCiAgICAgICAgPiA+ID4gLS0tDQogICAgICAgID4gPiA+ICBsaWIvbGlicnRl X3JpbmcvcnRlX3JpbmdfYzExX21lbS5oIHwgMyArKy0NCiAgICAgICAgPiA+ID4gIDEgZmlsZSBj aGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkNCiAgICAgICAgPiA+ID4gDQog ICAgICAgID4gVGhlIHJlYWQgb2YgaHQtPnRhaWwgbmVlZHMgdG8gYmUgYXRvbWljLCBhIG5vbi1h dG9taWMgcmVhZCB3b3VsZCBub3QgYmUgY29ycmVjdC4NCiAgICAgICAgDQogICAgICAgIFRoYXQn cyBhIDMyYml0IHZhbHVlIGxvYWQuDQogICAgICAgIEFGQUlLIG9uIGFsbCBDUFVzIHRoYXQgd2Ug c3VwcG9ydCBpdCBpcyBhbiBhdG9taWMgb3BlcmF0aW9uLg0KICAgIFtPbGFdIEJ1dCB0aGF0IHRo ZSBvcmRpbmFyeSBDIGxvYWQgaXMgdHJhbnNsYXRlZCB0byBhbiBhdG9taWMgbG9hZCBmb3IgdGhl IHRhcmdldCBhcmNoaXRlY3R1cmUgaXMgaW5jaWRlbnRhbC4NCiAgICANCiAgICBJZiB0aGUgZGVz aWduIHJlcXVpcmVzIGFuIGF0b21pYyBsb2FkICh3aGljaCBpcyB0aGUgY2FzZSBoZXJlKSwgd2Ug c2hvdWxkIHVzZSBhbiBhdG9taWMgbG9hZCBvbiB0aGUgbGFuZ3VhZ2UgbGV2ZWwuIFRoZW4gd2Ug Y2FuIGJlIHN1cmUgaXQgd2lsbCBhbHdheXMgYmUgdHJhbnNsYXRlZCB0byBhbiBhdG9taWMgbG9h ZCBmb3IgdGhlIHRhcmdldCBpbiBxdWVzdGlvbiBvciBjb21waWxhdGlvbiB3aWxsIGZhaWwuIFdl IGRvbid0IGhhdmUgdG8gZGVwZW5kIG9uIGFzc3VtcHRpb25zLg0KICAgIA0KICAgIA0KICAgICAg ICANCiAgICAgICAgPiBCdXQgdGhlcmUgYXJlIG5vIG1lbW9yeSBvcmRlcmluZyByZXF1aXJlbWVu dHMgKHdpdGgNCiAgICAgICAgPiByZWdhcmRzIHRvIG90aGVyIGxvYWRzIGFuZC9vciBzdG9yZXMg YnkgdGhpcyB0aHJlYWQpIHNvIHJlbGF4ZWQgbWVtb3J5IG9yZGVyIGlzIHN1ZmZpY2llbnQuDQog ICAgICAgID4gQW5vdGhlciBhc3BlY3Qgb2YgdXNpbmcgX19hdG9taWNfbG9hZF9uKCkgaXMgdGhh dCB0aGUgY29tcGlsZXIgY2Fubm90ICJvcHRpbWlzZSIgdGhpcyBsb2FkIChlLmcuIGNvbWJpbmUs IGhvaXN0IGV0YyksIGl0IGhhcyB0byBiZSBkb25lIGFzDQogICAgICAgID4gc3BlY2lmaWVkIGlu IHRoZSBzb3VyY2UgY29kZSB3aGljaCBpcyBhbHNvIHdoYXQgd2UgbmVlZCBoZXJlLg0KICAgICAg ICANCiAgICAgICAgSSB0aGluayBKZXJpbiBwb2ludHMgdGhhdCBydGVfcGF1c2UoKSBhY3RzIGhl cmUgYXMgY29tcGlsZXIgYmFycmllciB0b28sDQogICAgICAgIHNvIG5vIG5lZWQgdG8gd29ycnkg dGhhdCBjb21waWxlciB3b3VsZCBvcHRpbWl6ZSBvdXQgdGhlIGxvb3AuDQogICAgW09sYV0gU29y cnkgbWlzc2VkIHRoYXQuIEJ1dCB0aGUgYmFycmllciBiZWhhdmlvdXIgb2YgcnRlX3BhdXNlKCkg aXMgbm90IHBhcnQgb2YgQzExLCBpcyBpdCBlc3NlbnRpYWxseSBhIGhhbmQtbWFkZSBmZWF0dXJl IHRvIHN1cHBvcnQgdGhlIGxlZ2FjeSBtdWx0aXRocmVhZGVkIG1lbW9yeSBtb2RlbCAod2hpY2gg dXNlcyBleHBsaWNpdCBIVyBhbmQgY29tcGlsZXIgYmFycmllcnMpLiBJJ2QgcHJlZmVyIGNvZGUg dXNpbmcgdGhlIEMxMSBtZW1vcnkgbW9kZWwgbm90IHRvIGRlcGVuZCBvbiBzdWNoIGxlZ2FjeSBm ZWF0dXJlcy4NCiAgICANCiAgICANCiAgICANCiAgICAgICAgS29uc3RhbnRpbg0KICAgICAgICAN CiAgICAgICAgPiANCiAgICAgICAgPiBPbmUgcG9pbnQgd29ydGggbWVudGlvbmluZyB0aG91Z2gg aXMgdGhhdCB0aGlzIGNoYW5nZSBpcyBmb3IgdGhlIHJ0ZV9yaW5nX2MxMV9tZW0uaCBmaWxlLCBu b3QgdGhlIGxlZ2FjeSByaW5nLiBJdCBtYXkgYmUgd29ydGggcGVyc2lzdGluZw0KICAgICAgICA+ IHdpdGggZ2V0dGluZyB0aGUgQzExIGNvZGUgcmlnaHQgd2hlbiBwZW9wbGUgYXJlIGxlc3MgZXhj aXRlZCBhYm91dCBzZW5kaW5nIGEgcmVsZWFzZSBvdXQ/DQogICAgICAgID4gDQogICAgICAgID4g V2UgY2FuIGV4cGxhaW4gdGhhdCBmb3IgQzExIHdlIHdvdWxkIHByZWZlciB0byBkbyBsb2FkcyBh bmQgc3RvcmVzIGFzIHBlciB0aGUgQzExIG1lbW9yeSBtb2RlbC4gSW4gdGhlIGNhc2Ugb2YgcnRl X3JpbmcsIHRoZSBjb2RlIGlzDQogICAgICAgID4gc2VwYXJhdGVkIGNsZWFubHkgaW50byBDMTEg c3BlY2lmaWMgZmlsZXMgYW55d2F5Lg0KICAgICAgICA+IA0KICAgICAgICA+IEkgdGhpbmsgcmVh ZGluZyBodC0+dGFpbCB1c2luZyBfX2F0b21pY19sb2FkX24oKSBpcyB0aGUgbW9zdCBhcHByb3By aWF0ZSB3YXkuIFdlIHNob3cgdGhhdCBodC0+dGFpbCBpcyB1c2VkIGZvciBzeW5jaHJvbml6YXRp b24sIHdlDQogICAgICAgID4gYWNrbm93bGVkZ2UgdGhhdCBodC0+dGFpbCBtYXkgYmUgd3JpdHRl biBieSBvdGhlciB0aHJlYWRzIHdpdGhvdXQgYW55IG90aGVyIGtpbmQgb2Ygc3luY2hyb25pemF0 aW9uIChlLmcuIG5vIGxvY2sgaW52b2x2ZWQpIGFuZCB3ZSByZXF1aXJlDQogICAgICAgID4gYW4g YXRvbWljIGxvYWQgKGFueSB3cml0ZSB0byBodC0+dGFpbCBtdXN0IGFsc28gYmUgYXRvbWljKS4N CiAgICAgICAgPiANCiAgICAgICAgPiBVc2luZyB2b2xhdGlsZSBhbmQgZXhwbGljaXQgY29tcGls ZXIgKG9yIHByb2Nlc3NvcikgbWVtb3J5IGJhcnJpZXJzIChmZW5jZXMpIGlzIHRoZSBsZWdhY3kg cHJlLUMxMSB3YXkgb2YgYWNjb21wbGlzaGluZyB0aGVzZSB0aGluZ3MuIFRoZXJlJ3MNCiAgICAg ICAgPiBhIHJlYXNvbiB3aHkgQzExL0MrKzExIG1vdmVkIGF3YXkgZnJvbSB0aGUgb2xkIHdheXMu DQogICAgICAgID4gPiA+DQogICAgICAgID4gPiA+ICAgICAgICAgX19hdG9taWNfc3RvcmVfbigm aHQtPnRhaWwsIG5ld192YWwsIF9fQVRPTUlDX1JFTEVBU0UpOw0KICAgICAgICA+ID4gPiAtLQ0K ICAgICAgICA+ID4gPiAyLjcuNA0KICAgICAgICA+ID4gPg0KICAgICAgICANCiAgICANCiAgICAN Cg0K