From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] Pass verbose flag to kernel module Date: Wed, 15 Oct 2014 14:04:52 +0200 Message-ID: <6226905.S8oySLlmRr@xps13> References: <1412611749-7901-1-git-send-email-sergio.gonzalez.monroy@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: "De Lara Guarch, Pablo" , "Gonzalez Monroy, Sergio" Return-path: In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Sergio, I'd like to see a v2 patch with your explanations in commit log and with a Signed-off-by. > > - CROSS_COMPILE=$(CROSS) > > + V=$(if $(V),1,0) CROSS_COMPILE=$(CROSS) Minor nits: - paren is not needed for one letter variable - V option should go to the end to keep things sorted by importance - CROSS_COMPILE=$(CROSS) + CROSS_COMPILE=$(CROSS) V=$(if $V,1,0) > Acked-by: Pablo de Lara Please Pablo, do not give your ack if there is no Signed-off-by. It's mandatory. Thanks -- Thomas