From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v2] scripts: add script for generating
	customised build config
Date: Tue, 07 Jun 2016 09:36:37 +0200
Message-ID: <6235932.qgKH91Itup@xps13>
References: <1461061640-7611-1-git-send-email-bruce.richardson@intel.com>
 <1461944891-7280-1-git-send-email-bruce.richardson@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51])
 by dpdk.org (Postfix) with ESMTP id 838846CBA
 for <dev@dpdk.org>; Tue,  7 Jun 2016 09:36:39 +0200 (CEST)
Received: by mail-wm0-f51.google.com with SMTP id m124so101309095wme.1
 for <dev@dpdk.org>; Tue, 07 Jun 2016 00:36:39 -0700 (PDT)
In-Reply-To: <1461944891-7280-1-git-send-email-bruce.richardson@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Bruce

2016-04-29 16:48, Bruce Richardson:
> This patch adds in the configure.py script file. It can be used to
> generate custom build-time configurations for DPDK either manually on
> the commandline or by calling it from other scripts. It takes as parameters
> the base config template to use, and output directory to which the modified
> configuration will be written. Other optional parameters are then taken
> as y/n values which should be adjusted in the config file, and a special
> -m flag is provided to override the default RTE_MACHINE setting in the
> config template too.

You were planning to use this script but not make it the official way of
building DPDK. I think it should be the official way.
I would suggest to integrate it quietly and improve it to make it more
official later.
What do you think is missing in the current design to take it as a base
for later work?
I really would like to see the dependencies (internal and external)
managed in this script.

[...]
> +-m, --machine-type=TYPE
> +    Override the machine-type value given in the default configuration by
> +    setting it to TYPE. Using regular options, regular y/n values can be
> +    changed, but not string options, so this explicit override for machine
> +    type exists to allow changing it.

I think we should make possible to change string values as boolean ones in
a generic way.

Detail: the MAINTAINERS file must be updated for this new file.