From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v5 22/31] net/ice: support VLAN ops
Date: Mon, 17 Dec 2018 22:45:11 +0000
Message-ID: <62798d0e-ed0e-61f8-7201-1bacb8c6116c@intel.com>
References: <1542956179-80951-1-git-send-email-wenzhuo.lu@intel.com>
 <1545032259-77179-1-git-send-email-wenzhuo.lu@intel.com>
 <1545032259-77179-23-git-send-email-wenzhuo.lu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Qiming Yang <qiming.yang@intel.com>, Xiaoyun Li <xiaoyun.li@intel.com>,
 Jingjing Wu <jingjing.wu@intel.com>
To: Wenzhuo Lu <wenzhuo.lu@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 7B8D31B965
 for <dev@dpdk.org>; Mon, 17 Dec 2018 23:45:16 +0100 (CET)
In-Reply-To: <1545032259-77179-23-git-send-email-wenzhuo.lu@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 12/17/2018 7:37 AM, Wenzhuo Lu wrote:
> Add below ops,
> ice_vlan_filter_set
> ice_vlan_offload_set
> ice_vlan_tpid_set
> ice_vlan_pvid_set
> 
> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> Signed-off-by: Qiming Yang <qiming.yang@intel.com>
> Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
> ---
>  doc/guides/nics/features/ice.ini |   3 +
>  doc/guides/nics/ice.rst          |  16 ++
>  drivers/net/ice/ice_ethdev.c     | 590 +++++++++++++++++++++++++++++++++++++++
>  3 files changed, 609 insertions(+)
> 
> diff --git a/doc/guides/nics/features/ice.ini b/doc/guides/nics/features/ice.ini
> index 759a036..5ac8e56 100644
> --- a/doc/guides/nics/features/ice.ini
> +++ b/doc/guides/nics/features/ice.ini
> @@ -12,6 +12,9 @@ MTU update           = Y
>  Jumbo frame          = Y
>  Unicast MAC filter   = Y
>  Multicast MAC filter = Y
> +VLAN filter          = Y
> +VLAN offload         = Y
> +QinQ offload         = Y

To claim VLAN & QINQ support, data path also needs to be updated, to set proper
flags and vlan_tci & vlan_tci_outer on Rx path and to check and use them in Tx path.

This patch does not updates data path.