From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] ethdev: force offloading API rules Date: Fri, 08 Jun 2018 22:01:51 +0200 Message-ID: <6291522.OcHR8ZgW26@xps> References: <20180531124431.13746-1-ferruh.yigit@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Shahaf Shuler , Wei Dai , Qi Zhang , Andrew Rybchenko To: Ferruh Yigit Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 1CF331CDEB for ; Fri, 8 Jun 2018 22:01:53 +0200 (CEST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 08/06/2018 21:51, Ferruh Yigit: > On 5/31/2018 1:44 PM, Ferruh Yigit wrote: > > The error path was disabled in previous release to let apps to be more > > flexible. > > > > But this release they are enabled, applications have to obey offload API > > rules otherwise they will get errors from following APIs: > > rte_eth_dev_configure > > rte_eth_rx_queue_setup > > rte_eth_tx_queue_setup > > > > Signed-off-by: Ferruh Yigit > > --- > > Cc: Shahaf Shuler > > Cc: Wei Dai > > Cc: Qi Zhang > > Cc: Andrew Rybchenko > > Any objection to this patch? > I really would like to get this early to catch any possible issue. Yes you're right. Let's merge it.