From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] examples: remove unnecessary function calls Date: Mon, 15 Jan 2018 12:14:36 +0100 Message-ID: <6297491.ryl7qXoRam@xps> References: <20171211073129.4176-1-bhole_prashant_q7@lab.ntt.co.jp> <8ac37bf5-0fa7-ebb9-6b56-1247ed972e0b@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Ferruh Yigit , Pablo de Lara To: Prashant Bhole Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 3E4981041 for ; Mon, 15 Jan 2018 12:15:08 +0100 (CET) In-Reply-To: <8ac37bf5-0fa7-ebb9-6b56-1247ed972e0b@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 11/12/2017 19:12, Ferruh Yigit: > On 12/10/2017 11:31 PM, Prashant Bhole wrote: > > Removed rte_eth_dev_info_get() calls and declaration of struct rte_eth_dev_info > > where info is not used anymore > > > > Signed-off-by: Prashant Bhole > > Reviewed-by: Ferruh Yigit > > At any point in the history were they used? If so, can you please add the commit > making them unnecessary with "Fixes" tag? Maybe some were used. The first one I've checked was never used. Not worth spending time on it in my opinion. Applied, thanks