From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Burakov, Anatoly" Subject: Re: [PATCH v3] mem: Fix anonymous mapping on Power9. Date: Wed, 20 Feb 2019 16:44:07 +0000 Message-ID: <62bd3fe6-a3f4-8874-d49f-47703c364d65@intel.com> References: <20181116173538.5321-1-dwilder@us.ibm.com> <22f8d817-c649-2770-b86e-5229559bb13b@intel.com> <1920329.P3yoKYTqQv@xps> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, David Wilder , stable@dpdk.org, chaozhu@linux.vnet.ibm.com To: Thomas Monjalon Return-path: In-Reply-To: <1920329.P3yoKYTqQv@xps> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 20-Feb-19 4:27 PM, Thomas Monjalon wrote: > 20/02/2019 17:04, Burakov, Anatoly: >> On 16-Nov-18 5:35 PM, David Wilder wrote: >>> Removed the use of MAP_HUGETLB for anonymous mapping on ppc64. The >>> MAP_HUGETLB had previously been added to workaround issues on IBM Power8 >>> systems when mapping /dev/zero (see: commit >>> 284ae3e9ff9a92575c28c858efd2c85c8de6d440). In the current code the >>> MAP_HUGETLB flag will cause the anonymous mapping to fail on Power9. >>> Note, Power8 is currently failing to correctly mmap Hugepages, with and >>> without this change. >>> >>> Signed-off-by: David Wilder >>> Reviewed-by: Pradeep Satyanarayana >>> --- >> >> The changes are contained entirely to POWER9 code paths/docs, so while i >> cannot verify them working for obvious reasons, i have no objections to >> this patch. >> >> Acked-by: Anatoly Burakov > > It was applied a long time ago :) > I can see that now :) Someone replied to it and it bubbled up my inbox... -- Thanks, Anatoly