From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hemant Agrawal Subject: Re: [PATCH v3 1/4] Introducing SPDX License Identifiers Date: Fri, 15 Dec 2017 16:22:31 +0530 Message-ID: <63001fe4-2b0e-0f4d-60c2-e94201f13e9f@nxp.com> References: <1512117499-23412-1-git-send-email-hemant.agrawal@nxp.com> <1512718913-11462-1-git-send-email-hemant.agrawal@nxp.com> <4544178.LpVkm1JlzH@xps> <20171213113831.GA74296@bricha3-MOBL3.ger.corp.intel.com> <9A962A20-EFFC-45AD-ABD7-CC888080C4A9@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Cc: Thomas Monjalon , "dev@dpdk.org" , "stephen@networkplumber.org" , "Mcnamara, John" To: "Wiles, Keith" , "Richardson, Bruce" Return-path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0072.outbound.protection.outlook.com [104.47.32.72]) by dpdk.org (Postfix) with ESMTP id 59F042B9F for ; Fri, 15 Dec 2017 11:52:37 +0100 (CET) In-Reply-To: <9A962A20-EFFC-45AD-ABD7-CC888080C4A9@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thanks for all the comments. I will rework and post. Also, my bad for flip-flop but I have to agree with Stephen's suggestion to adapt Linux style. i.e. use SPDX tag in top line or 2nd line for scripts. This is for following reason: 1. DPDK will be using kernel tools such as checkpatch. 2. DPDK has common driver code between kernel and dpdk. It will be easy for contributors. Quoting from the Red's patch (https://patchwork.kernel.org/patch/10053699/) =>SPDX license tags are a thing now in the kernel[1]. It has also been decided to make them the first line in files. As Linus put it: "The real reason _I_ personally would like to see at least all the new SPDX lines to go at the very top of the file is that every time when we have some kind of ambiguity about placement, we end up with multiple cases, and then people don't notice when merging, and you end up having two - or you just end up having unnecessary merge conflicts because two different people picked two different choices)." regards, Hemant