From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] kni: Fix build on RHEL 8
Date: Wed, 19 Dec 2018 13:27:50 +0000
Message-ID: <631f3488-e43e-7252-aba1-1692f7092b44@intel.com>
References: <1543265151-14617-1-git-send-email-mgamal@redhat.com>
 <26d50d0f-8eb0-608f-9aed-5f3b39a85ff8@intel.com>
 <1543317202.5400.13.camel@redhat.com>
 <d77ca607-274b-df72-d8d3-db72bef61f1d@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
To: mgamal@redhat.com, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 87BA91B752
 for <dev@dpdk.org>; Wed, 19 Dec 2018 14:27:52 +0100 (CET)
In-Reply-To: <d77ca607-274b-df72-d8d3-db72bef61f1d@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 11/27/2018 1:38 PM, Ferruh Yigit wrote:
> On 11/27/2018 11:13 AM, Mohammed Gamal wrote:
>> On Tue, 2018-11-27 at 10:55 +0000, Ferruh Yigit wrote:
>>> On 11/26/2018 8:45 PM, Mohammed Gamal wrote:
>>>> As RHEL8 beta has been released and is based on recent upstream
>>>> kernels
>>>> which don't use ndo_change_mtu_rh74 function. Fix the build so that
>>>> it
>>>> doesn't fail because the function is missing
>>>>
>>>> Signed-off-by: Mohammed Gamal <mgamal@redhat.com>
>>>> ---
>>>>  kernel/linux/kni/compat.h | 3 ++-
>>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/kernel/linux/kni/compat.h b/kernel/linux/kni/compat.h
>>>> index 5aadebb..bc81d0c 100644
>>>> --- a/kernel/linux/kni/compat.h
>>>> +++ b/kernel/linux/kni/compat.h
>>>> @@ -103,7 +103,8 @@
>>>>  #endif
>>>>  
>>>>  #if (defined(RHEL_RELEASE_CODE) && \
>>>> -	(RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 5)))
>>>> +	(RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 5)) && \
>>>> +	(RHEL_RELEASE_CODE < RHEL_RELEASE_VERSION(8, 0)))
>>>>  #define ndo_change_mtu ndo_change_mtu_rh74
>>>
>>> What RHEL use, can you please confirm it turns back to
>>> `ndo_change_mtu`, instead
>>> of something like `ndo_change_mtu_rh8x`?
>>
>> There are no such functions in the RHEL8 kernel. You may check the
>> kernel source code from the SRPM available here:
>> http://ftp.redhat.com/redhat/rhel/rhel-8-beta/baseos/source/Packages/ke
>> rnel-4.18.0-32.el8.src.rpm
> 
> Thanks, I confirm `RH_KABI_RENAME` removed and RHEL8 is using original
> `ndo_change_mtu`
> 
> Minor issue, patch title should start with lowercase:
> 'kni: fix build on RHEL 8'
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 

Superseded by https://patches.dpdk.org/patch/49104/

Which has check for igb too.