From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v17 0/6] enable hotplug on multi-process Date: Tue, 16 Oct 2018 12:52:16 +0200 Message-ID: <6323427.7gbbtosImR@xps> References: <20180607123849.14439-1-qi.z.zhang@intel.com> <20181016001632.65357-1-qi.z.zhang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, gaetan.rivet@6wind.com, anatoly.burakov@intel.com, arybchenko@solarflare.com, konstantin.ananyev@intel.com, bruce.richardson@intel.com, ferruh.yigit@intel.com, benjamin.h.shelton@intel.com, narender.vangati@intel.com To: Qi Zhang Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 84A094CC7 for ; Tue, 16 Oct 2018 12:52:16 +0200 (CEST) In-Reply-To: <20181016001632.65357-1-qi.z.zhang@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Qi Zhang (6): > ethdev: add function to release port in secondary process > eal: enable hotplug on multi-process > eal: support attach or detach share device from secondary > drivers/net: enable hotplug on secondary process > drivers/net: enable device detach on secondary > examples/multi_process: add hotplug sample > > doc/guides/rel_notes/release_18_11.rst | 13 + > drivers/net/af_packet/rte_eth_af_packet.c | 6 +- > drivers/net/bnxt/bnxt_ethdev.c | 6 +- > drivers/net/bonding/rte_eth_bond_pmd.c | 6 +- > drivers/net/ena/ena_ethdev.c | 2 +- > drivers/net/kni/rte_eth_kni.c | 6 +- > drivers/net/liquidio/lio_ethdev.c | 2 +- > drivers/net/null/rte_eth_null.c | 6 +- > drivers/net/octeontx/octeontx_ethdev.c | 8 + > drivers/net/pcap/rte_eth_pcap.c | 6 +- > drivers/net/tap/rte_eth_tap.c | 8 +- > drivers/net/vhost/rte_eth_vhost.c | 6 +- > drivers/net/virtio/virtio_ethdev.c | 2 +- > examples/multi_process/Makefile | 1 + > examples/multi_process/hotplug_mp/Makefile | 23 ++ > examples/multi_process/hotplug_mp/commands.c | 214 ++++++++++++++ > examples/multi_process/hotplug_mp/commands.h | 10 + > examples/multi_process/hotplug_mp/main.c | 41 +++ > lib/librte_eal/bsdapp/eal/Makefile | 1 + > lib/librte_eal/common/eal_common_dev.c | 254 ++++++++++++++-- > lib/librte_eal/common/eal_private.h | 22 ++ > lib/librte_eal/common/hotplug_mp.c | 426 +++++++++++++++++++++++++++ > lib/librte_eal/common/hotplug_mp.h | 46 +++ > lib/librte_eal/common/include/rte_dev.h | 12 + > lib/librte_eal/common/include/rte_eal.h | 9 + > lib/librte_eal/common/meson.build | 1 + > lib/librte_eal/linuxapp/eal/Makefile | 1 + > lib/librte_eal/linuxapp/eal/eal.c | 6 + > lib/librte_ethdev/rte_ethdev.c | 17 +- > lib/librte_ethdev/rte_ethdev_driver.h | 16 +- > lib/librte_ethdev/rte_ethdev_pci.h | 10 +- > lib/librte_ethdev/rte_ethdev_version.map | 7 + > 32 files changed, 1151 insertions(+), 43 deletions(-) Applied, thanks. Note: some PMDs are updated to support multi-process hotplug, but not all of them. I think you focused on the generic ones (af_packet, pcap, tap, bonding), but you forgot failsafe. Please, could you follow-up in -rc2? Thank you