From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 0/2] introduce dev_ops to get extended statistics of a device Date: Tue, 23 Sep 2014 17:49:22 +0200 Message-ID: <6332355.DEeBjUGxto@xps13> References: <1406118534-6169-1-git-send-email-olivier.matz@6wind.com> <59AF69C657FD0841A61C55336867B5B0343B1737@IRSMSX103.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Olivier Matz Return-path: In-Reply-To: <59AF69C657FD0841A61C55336867B5B0343B1737-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-07-23 18:41, Richardson, Bruce: > > The generic statistics structure is getting bigger as new statistics are > > added in specific devices. For instance, fdir, tx_pause or loopback > > stats do not apply on virtual devices. It won't be possible to add every > > specific statistics in this generic stats structure, but on the other > > hand these specific statistics are useful for debugging purpose. > > > > This 2 patches introduces xstats_get() and xstats_reset() in > > dev_ops. When registered by a device, it can be used to provide > > arbitrary statistics that are identified by a name, as done by eththool > > in kernel. > > > > After that, some statistics could be moved from the generic structure to > > this new framework, but it will be part of another patch series as it > > should be discussed first. > > I like the idea, so Ack on the concept. :-) Applied with some minor fixes in the comments. Next step is to move some fields from rte_eth_stats to extended stats. First candidates to move are the VF-only counters. Thanks -- Thomas