From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH v2 0/3] vhost: disable iommu support by default Date: Tue, 7 Nov 2017 12:30:23 +0100 Message-ID: <63345029-2bc9-cbb5-aeeb-fa15260e807b@redhat.com> References: <20171103175735.24603-1-maxime.coquelin@redhat.com> <20171106203812.18428-1-maxime.coquelin@redhat.com> <25b7a450-37f8-48e7-4daf-90d23a507e82@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit To: Kevin Traynor , "Kavanagh, Mark B" , "dev@dpdk.org" , "yliu@fridaylinux.org" , "thomas@monjalon.net" , "Loftus, Ciara" Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 95D181B3DF for ; Tue, 7 Nov 2017 12:30:28 +0100 (CET) In-Reply-To: <25b7a450-37f8-48e7-4daf-90d23a507e82@redhat.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/07/2017 12:25 PM, Kevin Traynor wrote: > On 11/07/2017 10:56 AM, Kavanagh, Mark B wrote: >>> From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com] >>> Sent: Monday, November 6, 2017 8:38 PM >>> To: dev@dpdk.org; yliu@fridaylinux.org; Kavanagh, Mark B >>> ; thomas@monjalon.net; ktraynor@redhat.com >>> Cc: Maxime Coquelin >>> Subject: [PATCH v2 0/3] vhost: disable iommu support by default >>> >>> This series disables IOMMU feature by default, and introduce >>> a new flag passed at vhost device registration time to enable >>> it explicitly. >>> >>> When disabled, patch 1 also disables reply-ack protocol feature >>> to avoid Qemu v2.7.0-v2.9.0 reply-ack bug with multiqueue. >>> >>> Last patch adds a Vhost PMD "iommu-support" parameter to enable >>> the IOMMU feature. >> Hi Kevin, > Hi Maxime - OVS-DPDK does not use the vhost pmd, so that means that > iommu could not be used with OVS-DPDK at present. Did I get that right? No :) This is supported both with and without using Vhost PMD. When using the Vhost lib directly, you just have to pass RTE_VHOST_USER_IOMMU_SUPPORT flag to rte_vhost_driver_register(), this is patch 1. When using Vhost PMD, passing the iommu-support=1 option to the vdev cmdline will set this flag, this is patch 2. Thanks, Maxime > Ciara proposed patches for vhost pmd in OVS-DPDK but it is quite an > intrusive change and has been postponed multiple times due to various > issues. > > thanks, > Kevin. > >> Hi Maxime, >> >> I'm happy to confirm that this patchset resolves the vhost user mutltiq issue for OvS-DPDK, with QEMU v2.7.1. >> >> Additionally, all of the individual patches look good - thanks for all of your efforts on this! >> >> Tested-by: Mark Kavanagh >> Acked-by: Mark Kavanagh >> >> Cheers, >> Mark >> >>> >>> Maxime Coquelin (3): >>> vhost: disable reply-ack protocol feature if iommu feature disabled >>> vhost: add flag to enable iommu support >>> net: vhost: add iommu-support parameter to enable IOMMU feature >>> >>> doc/guides/nics/vhost.rst | 5 +++++ >>> doc/guides/prog_guide/vhost_lib.rst | 14 ++++++++++++++ >>> doc/guides/rel_notes/release_17_11.rst | 3 ++- >>> drivers/net/vhost/rte_eth_vhost.c | 13 +++++++++++++ >>> lib/librte_vhost/rte_vhost.h | 1 + >>> lib/librte_vhost/socket.c | 6 ++++++ >>> lib/librte_vhost/vhost_user.c | 24 ++++++++++++++++++++++-- >>> 7 files changed, 63 insertions(+), 3 deletions(-) >>> >>> -- >>> 2.13.6 >> >