DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Hiroshi Shimamoto <h-shimamoto-ehU+Cx/zZe18UrSeD/g0lQ@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org,
	Hayato Momma <h-momma-JhyGz2TFV9J8UrSeD/g0lQ@public.gmane.org>
Subject: Re: [memnic PATCH] linux: fix to disable softirq before netif_receive_skb()
Date: Mon, 30 Jun 2014 00:14:53 +0200	[thread overview]
Message-ID: <6362330.xvAMVmviSp@xps13> (raw)
In-Reply-To: <7F861DC0615E0C47A872E6F3C5FCDDBD01101844-ZmjkEB1lVlLt6d3pZDjeaEtBU8KWyXPq@public.gmane.org>

> Calling netif_receive_skb() from memnic thread may cause deadlock, if
> softirq is not disabled.
> 
> The netif_receive_skb() should be called in softirq context, but memnic
> thread is not softirq context. That may conflict softirq work like a
> timer handler in kernel network stack.
> 
> Signed-off-by: Hiroshi Shimamoto <h-shimamoto-ehU+Cx/zZe18UrSeD/g0lQ@public.gmane.org>
> Reviewed-by: Hayato Momma <h-momma-JhyGz2TFV9J8UrSeD/g0lQ@public.gmane.org>

Applied

Thanks
-- 
Thomas

      parent reply	other threads:[~2014-06-29 22:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-06  7:54 [memnic PATCH] linux: fix to disable softirq before netif_receive_skb() Hiroshi Shimamoto
     [not found] ` <7F861DC0615E0C47A872E6F3C5FCDDBD01101844-ZmjkEB1lVlLt6d3pZDjeaEtBU8KWyXPq@public.gmane.org>
2014-06-29 22:14   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6362330.xvAMVmviSp@xps13 \
    --to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    --cc=h-momma-JhyGz2TFV9J8UrSeD/g0lQ@public.gmane.org \
    --cc=h-shimamoto-ehU+Cx/zZe18UrSeD/g0lQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox