From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] eal: add rte_eal_iopl_init to version map
Date: Thu, 12 Feb 2015 16:28:40 +0100
Message-ID: <6385204.sJsWr1ttol@xps13>
References: <1423661455-27540-1-git-send-email-sergio.gonzalez.monroy@intel.com>
 <1762724.29i33vs4dM@xps13> <54DCC452.5010905@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev-VfR2kkLFssw@public.gmane.org
To: "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <54DCC452.5010905-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

2015-02-12 15:18, Gonzalez Monroy, Sergio:
> On 12/02/2015 15:12, Thomas Monjalon wrote:
> > 2015-02-11 13:30, Sergio Gonzalez Monroy:
> >> Common rte_eal_iopl_init function is missing from eal version map.
> > How did you see it?
> > Thanks
> Building shared libraries and using virtio PMD would result in undefined 
> reference symbol.
> Should I add it to the commit log?

Yes please.

> >>   	rte_eal_hpet_init;
> >> +	rte_eal_iopl_init;
> >>   	rte_eal_init;
> > You missed the alphabetical order, you were not so far ;)
> Oh, I did not realize it was alphabetical order, I'll send v2.

Thanks