From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2 1/6] examples/ipsec-secgw: fix
	initialization of aead crypto devices
Date: Sun, 22 Oct 2017 13:00:35 +0200
Message-ID: <6394702.IaL1MEG4G8@xps>
References: <1507987683-12315-1-git-send-email-aviadye@dev.mellanox.co.il>
 <E115CCD9D858EF4F90C690B0DCB4D8976CC3858D@IRSMSX108.ger.corp.intel.com>
 <522e9051-1390-f0b3-9796-8f4e8c323c62@dev.mellanox.co.il>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>, dev@dpdk.org,
 "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>,
 "aviadye@mellanox.com" <aviadye@mellanox.com>,
 "borisp@mellanox.com" <borisp@mellanox.com>,
 "akhil.goyal@nxp.com" <akhil.goyal@nxp.com>,
 "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>, "Nicolau,
 Radu" <radu.nicolau@intel.com>, "Doherty, Declan" <declan.doherty@intel.com>,
 "liranl@mellanox.com" <liranl@mellanox.com>,
 "nelio.laranjeiro@6wind.com" <nelio.laranjeiro@6wind.com>
To: Aviad Yehezkel <aviadye@dev.mellanox.co.il>
Return-path: <dev-bounces@dpdk.org>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 66F0C1B26E
 for <dev@dpdk.org>; Sun, 22 Oct 2017 13:00:38 +0200 (CEST)
In-Reply-To: <522e9051-1390-f0b3-9796-8f4e8c323c62@dev.mellanox.co.il>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

22/10/2017 09:21, Aviad Yehezkel:
> On 10/20/2017 12:50 PM, De Lara Guarch, Pablo wrote:
> > From: aviadye@dev.mellanox.co.il
> >> From: Aviad Yehezkel <aviadye@mellanox.com>
> >>
> >> Fixes: 501e9c226adf ("examples/ipsec-secgw: add AEAD parameters")
> >> Cc: pablo.de.lara.guarch@intel.com
> > 
> > You should CC stable here.
> 
> You referred me to http://dpdk.org/doc/guides/contributing/patches.html
> I followed the documentation:
> "
> When fixing a regression, it is required to reference the id of the 
> commit which introduced the bug, and put the original author of that 
> commit on CC. Yiu can generate the required lines using the following 
> git alias, which print the commit SHA and the author of the original code:
> git config alias.fixline "log -1 --abbrev=12 --format='Fixes: %h 
> (\"%s\")%nCc: %ae'"
> "
> Please explain when to use above alias and when to put stable or 
> something else.

It seems it is not described in the chapter 5.
It is mentioned only in chapter 6:
	http://dpdk.org/doc/guides/contributing/stable.html#the-stable-mailing-list

But when running devtools/check-git-log.sh as described in chapter 5:
	http://dpdk.org/doc/guides/contributing/patches.html#checking-the-patches
You should see this:
	Is it candidate for Cc: stable@dpdk.org backport?
It is using devtools/git-log-fixes.sh to get patches which are fixing
older releases.

Short answer:
You must add "Cc: stable@dpdk.org" just below "Fixes:" if the bug
was introduced in an older release.
It will trigger the patch to be backported in maintenance releases.

It is the responsibility of the tree maintainer to check this tag,
and add or remove it, if he thinks the backport requirement was not
properly considered.