Re: [PATCH v3 1/2] dts: refactor cryptodev throughput test suite

[Luca Vizzarro <Luca.Vizzarro@arm.com>]

On 19/10/2026 21:04, Andrew Bailey wrote:
>   class Config(BaseConfig):
>       """Performance test metrics.
>   
>       Attributes:
>           delta_tolerance: The allowed tolerance below a given baseline.
> -        throughput_test_parameters: The test parameters to use in the test suite.
> +        test_combinations: List of test combinations with cipher/auth algorithms and parameters.
>       """
Hey Andrew,

The refactor looks mostly fine. Even though it was previously merged 
like that, can we use this refactor to appropriately define the 
configuration of the test suite. Given this is not a simple TypedDict, 
you could perhaps use a Pydantic model to define the fields. just a 
dict[str, ...] is too vague and compromises configuration validation 
upon startup. Moreover the Pydantic-based configurations will render 
appropriately in the docs, so the user will know better how to configure 
that way. You can have a look at the config module to see how it was done.

Luca