From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: ethdev new offloading API switch in PMDs
Date: Wed, 2 May 2018 09:46:37 +0100
Message-ID: <63bfaed3-660b-34d7-d8db-87e55500bad3@intel.com>
References: <f8e59301-73ac-1296-5e0a-cb7c62a57f70@intel.com>
 <DB7PR05MB44266E311EC4A0EB60260379C3800@DB7PR05MB4426.eurprd05.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Thomas Monjalon <thomas@monjalon.net>, dpdk-dev <dev@dpdk.org>,
 Ravi Kumar <ravi1.kumar@amd.com>, Ajit Khaparde
 <ajit.khaparde@broadcom.com>, Somnath Kotur <somnath.kotur@broadcom.com>,
 Marcin Wojtas <mw@semihalf.com>, Michal Krawczyk <mk@semihalf.com>,
 Guy Tzalik <gtzalik@amazon.com>, Evgeny Schemeilin <evgenys@amazon.com>,
 Bruce Richardson <bruce.richardson@intel.com>
To: Shahaf Shuler <shahafs@mellanox.com>,
 Gaetan Rivet <gaetan.rivet@6wind.com>, Qi Zhang <qi.z.zhang@intel.com>,
 Xiao Wang <xiao.w.wang@intel.com>, Beilei Xing <beilei.xing@intel.com>,
 Wenzhuo Lu <wenzhuo.lu@intel.com>,
 Konstantin Ananyev <konstantin.ananyev@intel.com>,
 Adrien Mazarguil <adrien.mazarguil@6wind.com>,
 =?UTF-8?Q?N=c3=a9lio_Laranjeiro?= <nelio.laranjeiro@6wind.com>,
 Yongseok Koh <yskoh@mellanox.com>,
 Santosh Shukla <santosh.shukla@caviumnetworks.com>,
 Jerin Jacob <jerin.jacob@caviumnetworks.com>,
 Rasesh Mody <rasesh.mody@cavium.com>, Harish Patil
 <harish.patil@cavium.com>, Shahed Shaikh <shahed.shaikh@cavium.com>,
 Andrew Rybchenko <arybchenko@solarflare.com>,
 Pascal Mazon <pascal.mazon@6wind.com>,
 Maciej Czekaj <maciej.czekaj@caviumnetworks.com>,
 Maxime Coquelin <maxime.coquelin@redhat.com>, Tiwei Bie
 <tiwei.bie@intel.com>, Yong Wang <yongwang@vmware.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 0E5FD23B
 for <dev@dpdk.org>; Wed,  2 May 2018 10:46:45 +0200 (CEST)
In-Reply-To: <DB7PR05MB44266E311EC4A0EB60260379C3800@DB7PR05MB4426.eurprd05.prod.outlook.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 5/2/2018 6:34 AM, Shahaf Shuler wrote:
> Tuesday, May 1, 2018 5:01 PM, Ferruh Yigit:
>> Subject: ethdev new offloading API switch in PMDs
>>
>> Hi,
>>
>> Following PMDs still has .txq_flags in use, after basic grep, no in-dept
>> investigation done.
>>
>> With PMDs switch to new API, that flag no longer should be needed.
>>
>> Old applications still use it but ethdev converts them to the offloads, so that
>> PMDs can only concern about offloads.
>>
> 
> Full removal of txq_flags can be done only after we will mitigate the "queue offloads must match port offload" constrain.

Why? What is the relation of the flag and constrain?
Independent from constrain all PMDs switch to new API which doesn't use
txq_flags anymore, what blocks removing it from PMDs?

> 
>> Can maintainer of following PMDs please check their offloading API
>> implementation:
>>
>> axgbe
>> bnxt
>> e1000
>> ena
>> failsafe
>> fm10k
>> i40e
>> ixgbe
>> mlx4
>> mlx5
>> octeontx
>> qede
>> sfc
>> tap
>> thunderx
>> virtio
>> vmxnet3