From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 7/7]app/testpmd: add commands and config functions for i40e flow director support Date: Thu, 28 Aug 2014 10:50:37 +0200 Message-ID: <6406194.6E43HquPHH@xps13> References: <1409105634-29980-1-git-send-email-jingjing.wu@intel.com> <8438692.KHYKcsiDRz@xps13> <9BB6961774997848B5B42BEC655768F8ADBF4E@SHSMSX104.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: "Wu, Jingjing" Return-path: In-Reply-To: <9BB6961774997848B5B42BEC655768F8ADBF4E-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-08-28 03:51, Wu, Jingjing: > From: Thomas Monjalon [mailto:thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org] > > 2014-08-27 10:13, Jingjing Wu: > > > add structure definition to construct programming packet. > > > > What is a "programming packet"? > > For Fortville, we need to set a flow director filter by sending a > packet which contains the input set values through the queue > belonging to flow director. OK. To be more clear, some detailed explanations are required in the commit log. Please try to be very descriptive. You can think comments like this: - if comments are absolutely needed to understand the code, you should put comments in the code (or write the code differently) - if some feature context can help for the review, you should explain context and design in the commit log > > > +#ifdef RTE_LIBRTE_I40E_PMD > > > + "i40e_flow_director_filter (port_id) (add|del)" > > > + " flow (ip4|ip6) src (src_ip_address) dst (dst_ip_address)" > > > + " flexwords (flexwords_value) (drop|fwd)" > > > + " queue (queue_id) fd_id (fd_id_value)\n" > > > + " Add/Del a IP type flow director filter for i40e NIC.\n\n" > > > + > > > + "i40e_flow_director_filter (port_id) (add|del)" > > > + " flow (udp4|tcp4|udp6|tcp6)" > > > + " src (src_ip_address) (src_port)" > > > + " dst (dst_ip_address) (dst_port)" > > > + " flexwords (flexwords_value) (drop|fwd)" > > > + " queue (queue_id) fd_id (fd_id_value)\n" > > > + " Add/Del a UDP/TCP type flow director filter for i40e NIC.\n\n" > > > + > > > + "i40e_flush_flow_diretor (port_id)\n" > > > + " Flush all flow director entries of a device on i40e NIC.\n\n" > > > +#endif /* RTE_LIBRTE_I40E_PMD */ > > > > I'd really like to stop seeing this kind of thing. > > We cannot add some ifdef for each PMD in generic code. > > > > I stopped reading after that. > > > > Sorry, I don't want to be rude but my feeling is that adding such feature > > with global picture in mind is not easy. I know you want to offer all i40e > > capabilities but you should think at future evolutions and how other drivers > > will be integrated with yours. > > > > Sorry to make you feel uncomfortable for such code. Just as you say, > I want to offer more i40e capabilities. I will rework code in testpmd. Thanks -- Thomas