From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3] examples/skeleton-cat: PQoS CAT and CDP, example of libpqos usage Date: Fri, 11 Mar 2016 17:38:41 +0100 Message-ID: <6409326.IYvTj83Jur@xps13> References: <1456499233-66251-1-git-send-email-wojciechx.andralojc@intel.com> <20160311162706.GD19860@bricha3-MOBL3> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, "Cornu, Marcel D" To: "Kantecki, Tomasz" Return-path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id B07B82C45 for ; Fri, 11 Mar 2016 17:40:25 +0100 (CET) Received: by mail-wm0-f42.google.com with SMTP id l68so25255120wml.0 for ; Fri, 11 Mar 2016 08:40:25 -0800 (PST) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-03-11 16:34, Kantecki, Tomasz: > > > > > > The skeleton aims to show a minimal piece of code (but bigger than > > > > > hello world). > > > > > For any other usage, I think the "l2fwd" name is more appropriate. > > > > > > > > > > > +DIRS-y += skeleton-cat > > > > > > > > > > > > > We have used skeleton app as basis for this sample code. It is just to keep > > it as simple as possible. > > > > Wouldn't it be confusing if we use "l2fwd" name for skeleton app > > functionality? > > > > > > I'm not sure. > > > We need more opinions. > > > > Skeleton app does do a form of l2 forwarding, just without editing the mac > > addresses. > > I don't think having "skeleton" in the name of derived apps is a good thing, so > > I would vote for an l2fwd-based name. > > OK I understand. We'll prepare patch v5 with changed application name. > Is Mon morning OK for the v5 patch submission? The deadline was yesterday. But for a new example, it can be integrated later, even in rc2 if rc1 is closed Monday (far from probable).