From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] bnxt: fix receive VLAN offload flags
Date: Tue, 26 Mar 2019 17:37:32 +0000
Message-ID: <642f7bb4-6439-1cef-1b52-0a32cf8f73a5@intel.com>
References: <20190325212754.13786-1-stephen@networkplumber.org>
 <CACZ4nhvyHcebyCUxX4xoOUJj=AuRZZ7XeQsAejoPFQ3Cy7Kpew@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: Somnath Kotur <somnath.kotur@broadcom.com>, dev@dpdk.org,
 Stephen Hemminger <sthemmin@microsoft.com>, Rasesh Mody <rmody@marvell.com>,
 Shahed Shaikh <shshaikh@marvell.com>, Hemant Agrawal
 <hemant.agrawal@nxp.com>, Shreyansh Jain <shreyansh.jain@nxp.com>,
 Allain Legacy <allain.legacy@windriver.com>,
 Matt Peters <matt.peters@windriver.com>, Qi Zhang <qi.z.zhang@intel.com>,
 Xiao Wang <xiao.w.wang@intel.com>
To: Ajit Khaparde <ajit.khaparde@broadcom.com>,
 Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 293BD1B441
 for <dev@dpdk.org>; Tue, 26 Mar 2019 18:37:36 +0100 (CET)
In-Reply-To: <CACZ4nhvyHcebyCUxX4xoOUJj=AuRZZ7XeQsAejoPFQ3Cy7Kpew@mail.gmail.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 3/25/2019 9:34 PM, Ajit Khaparde wrote:
> On Mon, Mar 25, 2019 at 2:28 PM Stephen Hemminger <
> stephen@networkplumber.org> wrote:
> 
>> From: Stephen Hemminger <sthemmin@microsoft.com>
>>
>> The bnxt driver is not correctly setting the receive VLAN offload
>> flags. When VLAN is offloaded the driver must set the PKT_RX_VLAN_STRIPPED
>> flag.
>>
>> Actually, several drivers have the same bug, only most of the
>> Intel drivers look right. Any driver that sets vlan_tci is probably
>> stripping the tag, and should be setting RX_VLAN_STRIPPED.
>>
>> To quote rte_mbuf.h:
>>
>> /**
>>  * The RX packet is a 802.1q VLAN packet, and the tci has been
>>  * saved in in mbuf->vlan_tci.
>>  * If the flag PKT_RX_VLAN_STRIPPED is also present, the VLAN
>>  * header has been stripped from mbuf data, else it is still
>>  * present.
>>  */
>>
>> Fixes: 2eb53b134aae ("net/bnxt: add initial Rx code")
>> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
>>
> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>

Applied to dpdk-next-net/master, thanks.


In a quick glance, following PMDs as well set "PKT_RX_VLAN" but not
"PKT_RX_VLAN_STRIPPED", their maintainers are cc'ed, can you please double check:

- bnx2x
- qede (it doesn't set 'vlan_tci' if not stripped, should be fixed)
- dpaa2
- dpaa (is 'vlan_tci' set?)
- avp
- fm10k