From mboxrd@z Thu Jan  1 00:00:00 1970
From: nickcooper-zhangtonghao <nic@opencloud.tech>
Subject: Re: [PATCH] memzone: Check socket_id value when creating
 memzone.
Date: Wed, 17 May 2017 08:31:00 +0800
Message-ID: <64D8B430-8FFD-4F77-B1C4-333023925213@opencloud.tech>
References: <1494569023-7564-1-git-send-email-nic@opencloud.tech>
 <20170512084220.GB53020@bricha3-MOBL3.ger.corp.intel.com>
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from smtpbguseast2.qq.com (smtpbguseast2.qq.com [54.204.34.130])
 by dpdk.org (Postfix) with ESMTP id 5DD43292D
 for <dev@dpdk.org>; Wed, 17 May 2017 02:31:04 +0200 (CEST)
In-Reply-To: <20170512084220.GB53020@bricha3-MOBL3.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


> On May 12, 2017, at 4:42 PM, Bruce Richardson =
<bruce.richardson@intel.com> wrote:
>=20
> On Thu, May 11, 2017 at 11:03:43PM -0700, Tonghao Zhang wrote:
>> If the socket_id is invalid (e.g. -2, -3), the
>> memzone_reserve_aligned_thread_unsafe should return the
>> EINVAL and not ENOMEM. To avoid it, we should check the
>> socket_id before calling malloc_heap_alloc.
>>=20
>> Signed-off-by: Tonghao Zhang <nic@opencloud.tech>
>> ---
>> lib/librte_eal/common/eal_common_memzone.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>=20
>> diff --git a/lib/librte_eal/common/eal_common_memzone.c =
b/lib/librte_eal/common/eal_common_memzone.c
>> index 64f4e0a..3026e36 100644
>> --- a/lib/librte_eal/common/eal_common_memzone.c
>> +++ b/lib/librte_eal/common/eal_common_memzone.c
>> @@ -189,7 +189,8 @@
>> 		return NULL;
>> 	}
>>=20
>> -	if ((socket_id !=3D SOCKET_ID_ANY) && (socket_id >=3D =
RTE_MAX_NUMA_NODES)) {
>> +	if ((socket_id !=3D SOCKET_ID_ANY) &&
>> +	    (socket_id >=3D RTE_MAX_NUMA_NODES || socket_id < 0)) {
>> 		rte_errno =3D EINVAL;
>> 		return NULL;
>> 	}
>> --=20
>=20
> Looks a sensible thing to do.
>=20
> Acked-by: Bruce Richardson <bruce.richardson@intel.com =
<mailto:bruce.richardson@intel.com>>


Thanks for your review.