From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shreyansh Jain Subject: Re: [PATCH] doc: add deprecation note for rework of PCI in EAL Date: Tue, 14 Feb 2017 10:48:39 +0530 Message-ID: <64d01f74-ec13-cd75-210c-322f9ddcd20b@nxp.com> References: <1486986909-27597-1-git-send-email-shreyansh.jain@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Cc: , , Thomas Monjalon To: Jan Blunck Return-path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0082.outbound.protection.outlook.com [104.47.32.82]) by dpdk.org (Postfix) with ESMTP id 3E76C2A5E for ; Tue, 14 Feb 2017 06:13:56 +0100 (CET) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tuesday 14 February 2017 03:26 AM, Jan Blunck wrote: > On Mon, Feb 13, 2017 at 1:00 PM, Shreyansh Jain wrote: >> On Monday 13 February 2017 05:25 PM, Shreyansh Jain wrote: >>> >>> EAL PCI layer is planned to be restructured in 17.05 to unlink it from >>> generic structures like eth_driver, rte_cryptodev_driver, and also move >>> it into a PCI Bus. >>> >>> Signed-off-by: Shreyansh Jain >>> --- >>> doc/guides/rel_notes/deprecation.rst | 12 ++++++++---- >>> 1 file changed, 8 insertions(+), 4 deletions(-) >>> >>> diff --git a/doc/guides/rel_notes/deprecation.rst >>> b/doc/guides/rel_notes/deprecation.rst >>> index fbe2fcb..b12d435 100644 >>> --- a/doc/guides/rel_notes/deprecation.rst >>> +++ b/doc/guides/rel_notes/deprecation.rst >>> @@ -13,10 +13,14 @@ Deprecation Notices >>> has exposed, like the way we have done with uio-pci-generic. This >>> change >>> targets release 17.05. >>> >>> -* ``eth_driver`` is planned to be removed in 17.02. This currently serves >>> as >>> - a placeholder for PMDs to register themselves. Changes for ``rte_bus`` >>> will >>> - provide a way to handle device initialization currently being done in >>> - ``eth_driver``. >> >> >> Just to highlight, above statement was added by me in 16.11. >> As of now I plan to work on removing rte_pci_driver from eth_driver, >> rather than removing eth_driver all together (which, probably, was >> better idea). >> If someone still wishes to work on its complete removal, we can keep >> the above. (and probably remove the below). >> > > There is no benefit in keeping eth_driver and removing rte_pci_driver > from it. Technically it isn't even needed today. I agree with you. I stopped working on it because I realized that removing it means making pci_probe call eth_dev_init handlers directly. Or, restructure the whole of pci probe stack - which, because of pending PCI bus implementation, was slightly tentative. Changes are already expected in EAL PCI code for bus movement, probably this task can be combined with that. > >> >>> +* ABI/API changes are planned for 17.05 for PCI subsystem. This is to >>> + unlink EAL dependency on PCI and to move PCI devices to a PCI specific >>> + bus. >>> + >>> +* ``rte_pci_driver`` is planned to be removed from ``eth_driver`` in >>> 17.05. >>> + This is to unlink the ethernet driver from PCI dependencies. >>> + Similarly, ``rte_pci_driver`` in planned to be removed from >>> + ``rte_cryptodev_driver`` in 17.05. >>> >>> * In 17.02 ABI changes are planned: the ``rte_eth_dev`` structure will be >>> extended with new function pointer ``tx_pkt_prepare`` allowing >>> verification >>> >> >