From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH] net/failsafe: fix Rx burst infinite loop Date: Wed, 24 Jan 2018 17:28:27 +0000 Message-ID: <64d96e5a-b312-cd63-8ab1-e564e202e8b9@intel.com> References: <1516789157-9234-1-git-send-email-matan@mellanox.com> <20180124103138.5npqmzijmlqkf3ue@bidouze.vm.6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: dev@dpdk.org To: =?UTF-8?Q?Ga=c3=abtan_Rivet?= , Matan Azrad Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id C4EE31B173 for ; Wed, 24 Jan 2018 18:28:30 +0100 (CET) In-Reply-To: <20180124103138.5npqmzijmlqkf3ue@bidouze.vm.6wind.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/24/2018 10:31 AM, Gaëtan Rivet wrote: > On Wed, Jan 24, 2018 at 10:19:17AM +0000, Matan Azrad wrote: >> In case of plugged out device, the fail-safe PMD uses failsafe_rx_burst >> function for packet receiving. >> >> This function iterates over the present sub-devices until it >> receives a traffic from one of them or they are all cannot receive >> packets. >> >> The corrupted code didn't advance the sub-device pointer when the >> sub-device was not present and caused to infinite loop. >> >> Advance the sub-device pointer also in plugged-out sub-device case. >> >> Fixes: 8052bbd9d548 ("net/failsafe: improve Rx sub-devices iteration") >> >> Signed-off-by: Matan Azrad > Acked-by: Gaetan Rivet Applied to dpdk-next-net/master, thanks.