From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hemant Agrawal <hemant.agrawal@nxp.com>
Subject: Re: [PATCH] crypto/dpaa2_sec: fix HMAC supported key
	sizes
Date: Thu, 27 Jul 2017 19:27:46 +0530
Message-ID: <6520377e-bf24-a340-85b4-620b66d91fe9@nxp.com>
References: <20170725052457.43952-1-pablo.de.lara.guarch@intel.com>
 <20170727115408.20386-1-akhil.goyal@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <pablo.de.lara.guarch@intel.com>, <stable@dpdk.org>
To: Akhil Goyal <akhil.goyal@nxp.com>, <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <20170727115408.20386-1-akhil.goyal@nxp.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 7/27/2017 5:24 PM, Akhil Goyal wrote:
> For HMAC algorithms (MD5-HMAC, SHAx-HMAC), the supported
> key sizes are not a fixed value, but a range between
> 1 and the block size.
>
> Fixes: 623326dded3a ("crypto/dpaa2_sec: introduce poll mode driver")
> Cc: stable@dpdk.org
>
> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
> ---
>  drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h b/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h
> index e104f71..3849a05 100644
> --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h
> +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h
> @@ -200,9 +200,9 @@ static const struct rte_cryptodev_capabilities dpaa2_sec_capabilities[] = {
>  				.algo = RTE_CRYPTO_AUTH_MD5_HMAC,
>  				.block_size = 64,
>  				.key_size = {
> -					.min = 64,
> +					.min = 1,
>  					.max = 64,
> -					.increment = 0
> +					.increment = 1
>  				},
>  				.digest_size = {
>  					.min = 16,
> @@ -221,9 +221,9 @@ static const struct rte_cryptodev_capabilities dpaa2_sec_capabilities[] = {
>  				.algo = RTE_CRYPTO_AUTH_SHA1_HMAC,
>  				.block_size = 64,
>  				.key_size = {
> -					.min = 64,
> +					.min = 1,
>  					.max = 64,
> -					.increment = 0
> +					.increment = 1
>  				},
>  				.digest_size = {
>  					.min = 20,
> @@ -242,9 +242,9 @@ static const struct rte_cryptodev_capabilities dpaa2_sec_capabilities[] = {
>  				.algo = RTE_CRYPTO_AUTH_SHA224_HMAC,
>  				.block_size = 64,
>  				.key_size = {
> -					.min = 64,
> +					.min = 1,
>  					.max = 64,
> -					.increment = 0
> +					.increment = 1
>  				},
>  				.digest_size = {
>  					.min = 28,
> @@ -263,9 +263,9 @@ static const struct rte_cryptodev_capabilities dpaa2_sec_capabilities[] = {
>  				.algo = RTE_CRYPTO_AUTH_SHA256_HMAC,
>  				.block_size = 64,
>  				.key_size = {
> -					.min = 64,
> +					.min = 1,
>  					.max = 64,
> -					.increment = 0
> +					.increment = 1
>  				},
>  				.digest_size = {
>  						.min = 32,
> @@ -284,9 +284,9 @@ static const struct rte_cryptodev_capabilities dpaa2_sec_capabilities[] = {
>  				.algo = RTE_CRYPTO_AUTH_SHA384_HMAC,
>  				.block_size = 128,
>  				.key_size = {
> -					.min = 128,
> +					.min = 1,
>  					.max = 128,
> -					.increment = 0
> +					.increment = 1
>  				},
>  				.digest_size = {
>  					.min = 48,
> @@ -305,9 +305,9 @@ static const struct rte_cryptodev_capabilities dpaa2_sec_capabilities[] = {
>  				.algo = RTE_CRYPTO_AUTH_SHA512_HMAC,
>  				.block_size = 128,
>  				.key_size = {
> -					.min = 128,
> +					.min = 1,
>  					.max = 128,
> -					.increment = 0
> +					.increment = 1
>  				},
>  				.digest_size = {
>  					.min = 64,
>
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>