From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: Re: [PATCH v8 17/25] drivers: convert PMD_VDEV drivers
 to use rte_vdev_driver
Date: Tue, 30 Aug 2016 10:08:17 +0530
Message-ID: <653509b8-5fc3-296f-ae73-cf1a33894387@nxp.com>
References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com>
 <1472219823-29486-1-git-send-email-shreyansh.jain@nxp.com>
 <1472219823-29486-18-git-send-email-shreyansh.jain@nxp.com>
 <57C46970.7020101@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <viktorin@rehivetech.com>, <david.marchand@6wind.com>,
 <thomas.monjalon@6wind.com>, <hemant.agrawal@nxp.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM02-SN1-obe.outbound.protection.outlook.com
 (mail-sn1nam02on0044.outbound.protection.outlook.com [104.47.36.44])
 by dpdk.org (Postfix) with ESMTP id B8AD82BD4
 for <dev@dpdk.org>; Tue, 30 Aug 2016 06:38:23 +0200 (CEST)
In-Reply-To: <57C46970.7020101@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Monday 29 August 2016 10:27 PM, Ferruh Yigit wrote:
> On 8/26/2016 2:56 PM, Shreyansh Jain wrote:
>> All PMD_VDEV drivers can now use rte_vdev_driver instead of the
>> rte_driver (which is embedded in the rte_vdev_driver).
>>
>> Signed-off-by: Jan Viktorin <viktorin@rehivetech.com>
>> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
>> ---
>
> ....
>
>> diff --git a/drivers/net/xenvirt/rte_eth_xenvirt.c b/drivers/net/xenvirt/rte_eth_xenvirt.c
>> index 6b15381..fa00e52 100644
>> --- a/drivers/net/xenvirt/rte_eth_xenvirt.c
>> +++ b/drivers/net/xenvirt/rte_eth_xenvirt.c
>> @@ -759,12 +759,14 @@ rte_pmd_xenvirt_devuninit(const char *name)
>>  	return 0;
>>  }
>
> xenvirt missing header file rte_vdev.h:
>
>   CC rte_eth_xenvirt.o
> ..../drivers/net/xenvirt/rte_eth_xenvirt.c:762:31: error: variable has
> incomplete type 'struct rte_vdev_driver'
> static struct rte_vdev_driver pmd_xenvirt_drv = {

Thanks for highlighting. I will fix this.

>
>
>>
>> -static struct rte_driver pmd_xenvirt_drv = {
>> -	.type = PMD_VDEV,
>> -	.init = rte_pmd_xenvirt_devinit,
>> -	.uninit = rte_pmd_xenvirt_devuninit,
>> +static struct rte_vdev_driver pmd_xenvirt_drv = {
>> +	.driver = {
>> +		.type = PMD_VDEV,
>> +		.init = rte_pmd_xenvirt_devinit,
>> +		.uninit = rte_pmd_xenvirt_devuninit
>> +	},
>>  };
>>
>> -PMD_REGISTER_DRIVER(pmd_xenvirt_drv, eth_xenvirt);
>> +DRIVER_REGISTER_VDEV(eth_xenvirt, pmd_xenvirt_drv);
>>  DRIVER_REGISTER_PARAM_STRING(eth_xenvirt,
>>  	"mac=<mac addr>");
>>
>
>

-
Shreyansh