From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [dpdk-stable] [PATCH] net/thunderx: fix Tx desc corruption in scatter-gather mode Date: Fri, 9 Nov 2018 20:25:52 +0000 Message-ID: <653b50e5-fd7c-3f15-1528-21422ad767d1@intel.com> References: <1541742633-798-1-git-send-email-nithin.dabilpuram@caviumnetworks.com> <20181109082000.GA4934@jerin> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" , "Jacob, Jerin" , "Czekaj, Maciej" , "Nilla, Subrahmanyam" , "stable@dpdk.org" To: Jerin Jacob , "Dabilpuram, Nithin" Return-path: In-Reply-To: <20181109082000.GA4934@jerin> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/9/2018 8:20 AM, Jerin Jacob wrote: <...> >> From: Subrahmanyam Nilla >> >> For performance reasons, word1 of send_hdr_s >> sub descriptor was not cleared assuming it is always >> having default value of zero since it comes from fixed >> offsets of SQ buffer. >> This is causing issues in case of SG mode because, >> the size of send command might change and hence the word1 >> of send_hdr_s is not always at fixed offsets of the SQ buffer >> and hence not having default value of zero. >> >> This fixes the issue by clearing the word1 in case of SG mode >> for every packet. >> >> Fixes: 1c421f18e0 ("net/thunderx: add single and multi-segment Tx") >> Cc: stable@dpdk.org >> >> Signed-off-by: Subrahmanyam Nilla >> Signed-off-by: Nithin Dabilpuram >> --- > > Acked-by: Jerin Jacob Applied to dpdk-next-net/master, thanks.