From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
Subject: Re: [PATCH] eal: remove single file segments related code
Date: Fri, 30 Sep 2016 15:48:48 +0100
Message-ID: <65601617-b4a2-4971-6482-af4810dbb34a@intel.com>
References: <1474614646-23648-1-git-send-email-yuanhan.liu@linux.intel.com>
 <3786074.FTf50R74LC@xps13> <20160923091448.GB23158@yliu-dev.sh.intel.com>
 <ED26CBA2FAD1BF48A8719AEF02201E364E68E27F@SHSMSX103.ccr.corp.intel.com>
 <CALwxeUuJbagx+1m7kdcgFh8jUt3TKvorCbD3nfS=4QPJx4Yq=Q@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Thomas Monjalon <thomas.monjalon@6wind.com>, "dev@dpdk.org"
 <dev@dpdk.org>, "Tan, Jianfeng" <jianfeng.tan@intel.com>
To: David Marchand <david.marchand@6wind.com>,
 Yuanhan Liu <yuanhan.liu@linux.intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 5FF492BCE
 for <dev@dpdk.org>; Fri, 30 Sep 2016 16:48:51 +0200 (CEST)
In-Reply-To: <CALwxeUuJbagx+1m7kdcgFh8jUt3TKvorCbD3nfS=4QPJx4Yq=Q@mail.gmail.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 30/09/2016 15:32, David Marchand wrote:
> On Fri, Sep 23, 2016 at 12:08 PM, Tan, Jianfeng <jianfeng.tan@intel.com> wrote:
>>> -----Original Message-----
>>> From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com]
>>> Sent: Friday, September 23, 2016 5:15 PM
>>> To: Thomas Monjalon
>>> Cc: dev@dpdk.org; David Marchand; Tan, Jianfeng
>>> Subject: Re: [PATCH] eal: remove single file segments related code
>>>
>>> On Fri, Sep 23, 2016 at 10:50:06AM +0200, Thomas Monjalon wrote:
>>>> 2016-09-23 15:10, Yuanhan Liu:
>>>>> Commit c711ccb30987 ("ivshmem: remove library and its EAL integration")
>>>>> removed ivshmem support, but seems David forgot to remove the another
>>>>> piece of code: code for RTE_EAL_SINGLE_FILE_SEGMENTS, which is
>>> introduced
>>>>> when ivshmem was firstly added.
>>>> It is not a mistake. We thought it is used by container use case.
>>> I think no. It would help the container case a bit, but not too much I
>>> would think, especially when the memory goes fragement.
>>>
>>> Jianfeng, IIRC, you don't use that option for container case, right?
>>>
>>>        --yliu
>> No, I don't use this option for container case. As yuanhan said, it cannot provide much help for virtio_user memory region number limitation.
> Ok, as said, since this feature had been introduced with ivshmem
> 40b966a211ab ("ivshmem: library changes for mmaping using ivshmem"),
> if Sergio has nothing against this removal, I am all for removing
> unused code.

I certainly do not have anything against this removal :)

Acked-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>