From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Hunt, David" <david.hunt@intel.com>
Subject: Re: [PATCH v6 14/21] event/sw: add xstats support
Date: Thu, 30 Mar 2017 12:12:57 +0100
Message-ID: <65840fd1-9833-232b-bebc-645efc3fc9ce@intel.com>
References: <1490374395-149320-1-git-send-email-harry.van.haaren@intel.com>
 <1490829963-106807-1-git-send-email-harry.van.haaren@intel.com>
 <1490829963-106807-15-git-send-email-harry.van.haaren@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: jerin.jacob@caviumnetworks.com,
 Bruce Richardson <bruce.richardson@intel.com>
To: Harry van Haaren <harry.van.haaren@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 07BF010FAB
 for <dev@dpdk.org>; Thu, 30 Mar 2017 13:13:00 +0200 (CEST)
In-Reply-To: <1490829963-106807-15-git-send-email-harry.van.haaren@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


On 30/3/2017 12:25 AM, Harry van Haaren wrote:
> From: Bruce Richardson <bruce.richardson@intel.com>
>
> Add support for xstats to report out on the state of the eventdev.
> Useful for debugging and for unit tests, as well as observability
> at runtime and performance tuning of apps to work well with the
> scheduler.
>

--snip--

> +static int
> +sw_xstats_reset_port(struct sw_evdev *sw, uint8_t port_id,
> +		const uint32_t ids[], uint32_t nb_ids)
> +{
> +	const uint32_t reset = 1;
> +	const uint32_t ret_n_lt_stats = 0;
> +	int offset = sw->xstats_offset_for_port[port_id];
> +	int nb_stat = sw->xstats_count_per_port[port_id];
> +
> +	if (ids) {
> +		uint32_t nb_reset = sw_xstats_update(sw,
> +					RTE_EVENT_DEV_XSTATS_PORT, port_id,
> +					ids, NULL, nb_ids,
> +					reset, ret_n_lt_stats);
> +		return nb_reset == nb_ids ? 0 : -EINVAL;
> +	} else
> +		sw_xstats_reset_range(sw, offset, nb_stat);
> +
> +	return 0;
> +}

Checkpatch warning here:
WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or 
return
#747: FILE: drivers/event/sw/sw_evdev_xstats.c:611:
+               return nb_reset == nb_ids ? 0 : -EINVAL;
+       } else

So can be changed to

+		return nb_reset == nb_ids ? 0 : -EINVAL;
+	}
+
+	sw_xstats_reset_range(sw, offset, nb_stat);
+
+	return 0;


Apart from that:

Acked-by: David Hunt <david.hunt@intel.com>