From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] mk: fix app linking for combined libs Date: Fri, 28 Nov 2014 16:55:44 +0100 Message-ID: <6592533.mQvpkUAhuR@xps13> References: <1414078604-1090-1-git-send-email-sergio.gonzalez.monroy@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Sergio Gonzalez Monroy Return-path: In-Reply-To: <1414078604-1090-1-git-send-email-sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-10-23 16:36, Sergio Gonzalez Monroy: > Building combined shared libraries results in applications being linked > against separeted/individual and combined libs altogether. > > Link only against combined lib when the config option is enabled. > > Signed-off-by: Sergio Gonzalez Monroy [...] > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > @@ -217,6 +217,12 @@ endif > > endif # plugins > > +ifeq ($(RTE_BUILD_COMBINE_LIBS),y) > +LDLIBS = --whole-archive You are resetting LDLIBS here. It's not easy to read and probably not desired. I think it would be better to explicitly disable separated libs in this case. > +LDLIBS += --start-group > +LDLIBS += -l$(RTE_LIBNAME) > +endif Thanks -- Thomas