From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shreyansh Jain Subject: Re: [PATCH] bus/dpaa: fix memory allocation during bus scan Date: Tue, 10 Oct 2017 14:49:21 +0530 Message-ID: <65f378cb-2229-36d5-418a-1fedf9435cb0@nxp.com> References: <20171010070155.17412-1-shreyansh.jain@nxp.com> <2102754.igz1rhL23C@xps> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Cc: , , To: Thomas Monjalon Return-path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0050.outbound.protection.outlook.com [104.47.41.50]) by dpdk.org (Postfix) with ESMTP id 884631B209 for ; Tue, 10 Oct 2017 11:07:12 +0200 (CEST) In-Reply-To: <2102754.igz1rhL23C@xps> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tuesday 10 October 2017 01:09 PM, Thomas Monjalon wrote: > 10/10/2017 09:01, Shreyansh Jain: >> Fixes: 5b22cf744689 ("bus/dpaa: introducing FMan configurations") >> Fixes: 37f9b54bd3cf ("net/dpaa: support Tx and Rx queue setup") > > These lines should appear after the explanation. Ok. That I missed - I will fix and send updated patch. > >> Cc: shreyansh.jain@nxp.com >> >> With the IOVA auto detection changes, bus scan is performed before >> memory initialization. DPAA bus scan must not use rte_malloc in >> its path. > > If the scan has been broken by IOVA detection, you should reference > IOVA in Fixes line, not DPAA. I was of two minds before sending this patch with above Fixes lines: This change is because of IOVA but at the time IOVA patch was introduced, this bus was not part of master. So, ideally, in the net-next itself the integration should have been with fixed code - but, I ended up verifying base patches without IOVA patches (some earlier snapshot of net-next). Anyways, I will send another patch with IOVA as fix line.