From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3 06/12] memzone: refactor rte_memzone_reserve() variants Date: Thu, 09 Jul 2015 02:51:27 +0200 Message-ID: <6620352.tGbjSFjKPr@xps13> References: <1436172698-21749-1-git-send-email-zlu@ezchip.com> <1436172698-21749-7-git-send-email-zlu@ezchip.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Zhigang Lu Return-path: Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com [209.85.212.174]) by dpdk.org (Postfix) with ESMTP id 27E525A3E for ; Thu, 9 Jul 2015 02:52:33 +0200 (CEST) Received: by wiwl6 with SMTP id l6so3919395wiw.0 for ; Wed, 08 Jul 2015 17:52:33 -0700 (PDT) In-Reply-To: <1436172698-21749-7-git-send-email-zlu@ezchip.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-07-06 16:51, Zhigang Lu: > The definitions of rte_memzone_reserve_aligned() and > rte_memzone_reserve_bounded() were identical with the exception of the > bound argument passed into rte_memzone_reserve_thread_safe(). > > This patch removes this replication of code by unifying it into > rte_memzone_reserve_thread_safe(), which is then called by all three > variants of rte_memzone_reserve(). Ideally, some functions should be merged to avoid some #ifdef RTE_LIBRTE_XEN_DOM0.