From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3 6/6] test: add checks for cpu flags on armv8 Date: Fri, 30 Oct 2015 09:16:11 -0700 (PDT) Message-ID: <6645369.r3ghAFd0W5@xps13> References: <1446212826-19425-7-git-send-email-david.hunt@intel.com> <5633798B.2050708@intel.com> <20151030161106.4657232.16920.465@rehivetech.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Jan Viktorin Return-path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id D7D419208 for ; Fri, 30 Oct 2015 17:16:11 +0100 (CET) Received: by wmff134 with SMTP id f134so15632572wmf.0 for ; Fri, 30 Oct 2015 09:16:11 -0700 (PDT) In-Reply-To: <20151030161106.4657232.16920.465@rehivetech.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-10-30 17:11, Jan Viktorin: > Anyway, it is not clear, what has changed in the v3. Just the rte_cycles? > You should explain that at least in the 0000 patch. > Better to keep some history in each single commit (are there any rules in > dpdk for this? Just look how they do in kernel). The rule is to help reviewers ;) History in the cover letter is good. If there are also some history in each patch, it's better.