From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v8 0/3] new API to free consumed buffers in Tx ring Date: Wed, 19 Apr 2017 17:25:37 +0100 Message-ID: <66ddc3cb-67dc-25d5-8b58-4818cc929a69@intel.com> References: <20170315180226.5999-1-bmcfall@redhat.com> <20170324185555.18398-1-bmcfall@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Billy McFall , thomas.monjalon@6wind.com, wenzhuo.lu@intel.com, olivier.matz@6wind.com Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 5C8485688 for ; Wed, 19 Apr 2017 18:25:49 +0200 (CEST) In-Reply-To: <20170324185555.18398-1-bmcfall@redhat.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/24/2017 6:55 PM, Billy McFall wrote: > See request from 11/21/2016: > http://dpdk.org/ml/archives/dev/2016-November/050585.html > > Add a new API to free consumed buffers on TX ring. This addresses two > scenarios: > 1) Flooding a packet and want to reuse existing mbuf to avoid a packet > copy. Increment the reference count of the packet and poll new API until > reference count is decremented. > 2) Application runs out of mbufs, or resets and is preparing for > additional run, call API to free consumed packets so processing can > continue. > > API will return the number of packets freed (0-n) or error code if > feature not supported (-ENOTSUP) or input invalid (-ENODEV). > > API for e1000 igb driver and vHost driver have been implemented. Other > drivers can be implemented over time. Some drivers implement a Tx done > flush routine that should be reused where possible. e1000 igb driver > and vHost driver do not have such functions. Another reminder for PMDs. This is new eth_dev_ops, described above: "tx_done_cleanup" Currently only implemented by igb and vhost. Other PMDs feel free to implement new ops. Thanks, ferruh