From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B84F2C48BD3 for ; Wed, 26 Jun 2019 21:03:38 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 3FACB2086D for ; Wed, 26 Jun 2019 21:03:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=temperror (0-bit key) header.d=monjalon.net header.i=@monjalon.net header.b="dFpm5W0o"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="o4zCPLbZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3FACB2086D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5B4461E25; Wed, 26 Jun 2019 23:03:36 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id E680D3DC; Wed, 26 Jun 2019 23:03:33 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 3B1A722178; Wed, 26 Jun 2019 17:03:33 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 26 Jun 2019 17:03:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=MU/HakQAbGIvujOhAxx7NIWyEdU4whHKIIu/tFLqfvg=; b=dFpm5W0oqTV5 sYvGdsjbFVvoPCuxdgOu/fyRltWY4RIm3p6qJgnPJ014ogdE6aFvxWfA57Vjm8rf lnLsJu9+fTdgt11mFs/ydlW5Hr5Ohmje9odq6JXKKn8gLDrr44VfAHKGBNI6bH+A Za77nWD1bNroGUF/8j3CuGgYu/pYqk0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=MU/HakQAbGIvujOhAxx7NIWyEdU4whHKIIu/tFLqf vg=; b=o4zCPLbZzSw8Y8zSdiSgsy4H/LFvSX6sbg1kzqX/kL5uLuOFLfitdhYZb qZUor6p+7eXmoa3EAo2BG4pZazKlM6pceiOQNS3c7Wp76qNNObNDdaPkOCVA+QY+ 92jWDvVD9lvmkRq8mCtQBk2qAWrFXydqdc+flh9gSED3OEffhnEqFsg+gLkI1G9x 0aiP9fu58SlmdpeeQs6908yxtswaZwCztCuelHapehNW0LCbQAIFOSsahErSGW0B Z5NSTvNZvJlJdXVB63Z8z6hzMpT+richiB9z9Gq1n/XIJOHSX3+/cUdBUWpPgHgy jphowK+rdoopEF/Wm8kGFQPP+L10Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrudeigdduiedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id DA45580068; Wed, 26 Jun 2019 17:03:29 -0400 (EDT) From: Thomas Monjalon To: David Marchand Cc: dev@dpdk.org, Ilya Maximets , Anatoly Burakov , Jan Blunck , Qi Zhang , Kevin Traynor , dpdk stable , Gaetan Rivet Date: Wed, 26 Jun 2019 23:03:27 +0200 Message-ID: <6761573.WUIlbu0Kbq@xps> In-Reply-To: References: <20190606100228.19959-1-i.maximets@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] eal: fix positive error codes from probe/remove X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 07/06/2019 10:32, David Marchand: > On Thu, Jun 6, 2019 at 12:03 PM Ilya Maximets > wrote: > > > According to API, 'rte_dev_probe()' and 'rte_dev_remove()' must > > return 0 or negative error code. Bus code returns positive values > > if device wasn't recognized by any driver, so the result of > > 'bus->plug/unplug()' must be converted. 'local_dev_probe()' and > > 'local_dev_remove()' also has their internal API, so the conversion > > should be done there. > > > > Positive on remove means that device not found by driver. > > > > For backports, it is safer to add the check on > 0. > The patch looks good to me. > > Reviewed-by: David Marchand I did not get your comment. Is it OK to get this v2? What do you mean about backports?