From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] ethdev: fix applications failure on configure
Date: Tue, 1 May 2018 15:32:06 +0100
Message-ID: <68310139-6baf-baab-bbe9-3da0883960bc@intel.com>
References: <20180501133343.125260-1-ferruh.yigit@intel.com>
 <14979049.G4nOY0bchV@xps> <3b002b01-7baa-cd51-cfbe-a70e8b5a0ae1@intel.com>
 <6407794.aElEmAcKUa@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: xuemingl@mellanox.com, dev@dpdk.org
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id C0B7EDD2
 for <dev@dpdk.org>; Tue,  1 May 2018 16:32:09 +0200 (CEST)
In-Reply-To: <6407794.aElEmAcKUa@xps>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 5/1/2018 3:12 PM, Thomas Monjalon wrote:
> 01/05/2018 16:08, Ferruh Yigit:
>> On 5/1/2018 3:01 PM, Thomas Monjalon wrote:
>>> 01/05/2018 15:33, Ferruh Yigit:
>>>> Many sample applications fail because of
>>>> dev_info.flow_type_rss_offloads check in rte_eth_dev_configure()
>>>
>>> We need to define the API behaviour in doxygen.
>>>
>>>> The sample applications need to be fixed/updated before returning error
>>>> on rte_eth_dev_configure()
>>>>
>>>> This patch keeps the error log but removes returning error.
>>>
>>> If the doc is updated in 18.05, we can have a deprecation notice
>>> to insert the error return in 18.08.
>>
>> +1 to add a deprecation notice for this release and do the error return on 18.08.
>>
>> Is the doc update you mentioned doxygen update?
> 
> Yes, doxygen update.
> 
>> Who can do doc update and deprecation notice patches for this release?
> 
> Either you Ferruh, or Xueming and me together.
> What do you prefer?

Or as Xueming suggested, we can take rss_hf config as best effort and not return
error at all.

I think this forces PMDs to have up-to-date flow_type_rss_offloads values, is
there any other benefit?
What was the initial motivation to add error return on this check?

> 
>>>> Fixes: 8863a1fbfc66 ("ethdev: add supported hash function check")
>>>> Cc: xuemingl@mellanox.com
>>>>
>>>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> 
>